Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check conversion return in ASN1_INTEGER_print_bio. #6821

Closed
wants to merge 1 commit into from
Closed

Check conversion return in ASN1_INTEGER_print_bio. #6821

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

Check for failure in conversion.

Also streamline the code by relying on ASN1_INTEGER_to_BN to allocate the BN instead of doing it separately.

Refer #6820

@paulidale
Check conversion return in ASN1_INTEGER_print_bio.
254d13f 
Also streamline the code by relying on ASN1_INTEGER_to_BN to allocate the
BN instead of doing it separately.
levitte pushed a commit that referenced this pull request Jul 31, 2018
@paulidale
Check conversion return in ASN1_INTEGER_print_bio.
35c9408 
Also streamline the code by relying on ASN1_INTEGER_to_BN to allocate the
BN instead of doing it separately.

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #6821)
@paulidale
Copy link
Contributor Author

Merged.

@paulidale paulidale closed this Jul 31, 2018
@paulidale paulidale deleted the TS_ASN1_INTEGER_print_bio branch July 31, 2018 03:13
levitte pushed a commit that referenced this pull request Jul 31, 2018
@paulidale
Check conversion return in ASN1_INTEGER_print_bio.
35fa31c 
Also streamline the code by relying on ASN1_INTEGER_to_BN to allocate the
BN instead of doing it separately.

Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #6821)

(cherry picked from commit 35c9408)
@paulidale paulidale added approval: done This pull request has the required number of approvals 1.1.0 branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch labels Jul 31, 2018
@paulidale paulidale restored the TS_ASN1_INTEGER_print_bio branch July 31, 2018 03:23
@paulidale
Copy link
Contributor Author

Should this go back to 1.0.2?
It isn't a clean pick so would require a new PR.

@paulidale paulidale deleted the TS_ASN1_INTEGER_print_bio branch July 31, 2018 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-j-h t-j-h t-j-h approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulidale @t-j-h