rsa/rsa_ossl.c: implement variant of "Smooth CRT-RSA." [1.1.0] #6940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 23, 2018 22:52
Add bn_mul_fixed_top, bn_from_mont_fixed_top, bn_mod_sub_fixed_top.
Switch to bn_{mul|sqr}_fixed_top in bn_mul_mont_fixed_top and remove
memset in bn_from_montgomery_word.
(cherry picked from commit fcc4ee0)
In [most common] case of p and q being of same width, it's possible to replace CRT modulo operations with Montgomery reductions. And those are even fixed-length Montgomery reductions... (cherry picked from commit 41bfd5e) Resolved conflicts: crypto/rsa/rsa_ossl.c
(cherry picked from commit e02c519) Resolved conflicts: crypto/bn/bn_blind.c
(cherry picked from commit 324b956)
dot-asm
force-pushed
the
smooth_rsa-110
branch
from
d8079a8
to
f6c2c9a
Compare
|
Re-based and harmonized with master. |
levitte
changed the title
|
Which ping was it? Apparently there is magic one for this matter... P-i-i-i-i-i-i-n-g? |
|
Too little i's? All right, copy-n-pasting for #6915: "P-i-i-i-i-i-i-i-i-i-i-n-g then?" |
|
@paulidale care to review this one too? |
paulidale
approved these changes
Aug 28, 2018
levitte
pushed a commit
that referenced
this pull request
Aug 28, 2018
In [most common] case of p and q being of same width, it's possible to replace CRT modulo operations with Montgomery reductions. And those are even fixed-length Montgomery reductions... (cherry picked from commit 41bfd5e) Resolved conflicts: crypto/rsa/rsa_ossl.c Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #6940)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6915 backport to 1.1.0.