Fix typos in documentation. #7038
Conversation
CLA: trivial
| @@ -25,7 +25,7 @@ The message to sign or verify must be passed using the one-shot | |||
| EVP_DigestSign() and EVP_DigestVerify() functions. | |||
|
|
|||
| When calling EVP_DigestSignInit() or EVP_DigestVerifyInit(), the | |||
| digest parameter B<MUST> be set to B<NULL>. | |||
| digest B<type> parameter B<MUST> be set to B<NULL>. | |||
There was a problem hiding this comment.
I am not a native English speaker, but it seems if you want to address the parameter's name, place the name after the word 'parameter' sounds common - something like 'the digest parameter type MUST be set to NULL'.
Let's wait for others' opinions...
There was a problem hiding this comment.
Not a native speaker either, but having seen both forms... Anyway, we have an actual English speaker that has approved this, I suspect we can see that as an "ok" sign 😃
|
If one of @InfoHunter or @levitte can pick this up and fixup the CLA: trivial position in the commit message (this is trivial and we have a clear indicator) then this is good to go in. |
t-j-h
added
the
approval: done
CLA: trivial Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #7038)
|
@t-j-h , just so I know for the future, where should the CLA: trivial be in the commit message? I added it after the commit message separated by a blank line. |
|
Merged. fa332bb Fix typos in documentation. Thanks! |
|
@parasssh it is in the right place - was jumping between two PRs ... this one is good to go. It would be good to get a CLA on file for future contributions. |
|
@parasssh, your placement of |
|
@t-j-h I already have a approved CLA on file as of Aug 20, 2018. But I thought this PR is still trivial. |
|
Ahh. Excellent. I think where we have a CLA on file there is no need to mark a PR as trivial. |
|
That's right
…On Thu, Aug 23, 2018 at 3:42 PM Tim Hudson ***@***.***> wrote:
Ahh. Excellent. I think where we have a CLA on file there is no need to
mark a PR as trivial.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7038 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAwyxmF3c7qcKPQvNAFLu3KbQQNC1McBks5uTlzJgaJpZM4WI4j9>
.
--
Regards
Paul Yang
|
CLA: trivial
Checklist