Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl/ssl_ciph.c: make set_ciphersuites static #7253

Closed
wants to merge 1 commit into from
Closed

ssl/ssl_ciph.c: make set_ciphersuites static #7253

wants to merge 1 commit into from

Conversation

mspncp
Copy link
Contributor

@mspncp mspncp commented Sep 18, 2018

Fixes #7252

@mspncp mspncp mentioned this pull request Sep 18, 2018
Closed
t-j-h
t-j-h approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@t-j-h t-j-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on the CIs completing with success - this is approved.

@mspncp mspncp added branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch approval: done This pull request has the required number of approvals labels Sep 18, 2018
@mspncp
Copy link
Contributor Author

mspncp commented Sep 18, 2018

Sorry, I forgot to set the labels: I'll merge to 1.1.1 as well, if no one objects within the next two hours.

@t-j-h
Copy link
Member

t-j-h commented Sep 18, 2018

+1 on merge to 1.1.1

levitte pushed a commit that referenced this pull request Sep 18, 2018
@mspncp
ssl/ssl_ciph.c: make set_ciphersuites static
f9a2281 
Fixes #7252

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #7253)
levitte pushed a commit that referenced this pull request Sep 18, 2018
@mspncp
ssl/ssl_ciph.c: make set_ciphersuites static
f560ff6 
Fixes #7252

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from #7253)

(cherry picked from commit f9a2281)
@mspncp
Copy link
Contributor Author

mspncp commented Sep 18, 2018

Done.

@mspncp mspncp closed this Sep 18, 2018
@mspncp mspncp deleted the pr-make-set_ciphersuites-static branch September 18, 2018 07:49
@mspncp mspncp added this to the 1.1.1a milestone Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-j-h t-j-h t-j-h approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Milestone
1.1.1a
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mspncp @t-j-h @paulidale