Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-tls1_2 #7308

Closed
wants to merge 2 commits into from
Closed

Fix no-tls1_2 #7308

wants to merge 2 commits into from

Conversation

mattcaswell
Copy link
Member

No description provided.

@mattcaswell mattcaswell added branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch labels Sep 24, 2018
@mattcaswell
Copy link
Member Author

Fixup commit pushed to actually get the boolean logic right! I also spotted another error which I also fixed. Please can you reconfirm?

@mattcaswell
Copy link
Member Author

Pushed. Thanks.

levitte pushed a commit that referenced this pull request Sep 25, 2018
@mattcaswell
Fix no-tls1_2
7f1d923 
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #7308)
@mspncp mspncp mentioned this pull request Oct 13, 2018
Closed
@mspncp
Copy link
Contributor

mspncp commented Oct 14, 2018 •
edited

Shouldn't this pull request be cherry-picked to master 1.1.1? (see #7397)

@mattcaswell
Copy link
Member Author

Shouldn't this pull request be cherry-picked to 1.1.1? (see #7397)

Yes. And in fact the PR has the 1.1.1 label against it, which was there during the original approval. So I've backported it now and pushed.

levitte pushed a commit that referenced this pull request Oct 15, 2018
@mattcaswell
Fix no-tls1_2
89b0402 
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #7308)

(cherry picked from commit 7f1d923)
@mspncp mspncp added this to the 1.1.1a milestone Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-j-h t-j-h t-j-h approved these changes

Assignees
No one assigned
Labels
branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Milestone
1.1.1a
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattcaswell @mspncp @t-j-h