apps: Stop pretending to care about Netscape keys

[levitte]

The documentation says some commands care, but the code says differently.

[richsalz]

Nice!

[mspncp]

LGTM. But I'm in doubt whether this change is allowed to be backported to 1.1.1: even if the option was previously ignored (effectively), after your change the command fails because an unknown option is passed. This could break existing scripts. It might be unlikely that this is the case, but formally, it is a breaking change.

[paulidale]

For master only. I agree that for 1.1.1 it is an API change.

[levitte]

Ah... I could leave the option in with a comment, in apps/opt.c

[mspncp]

IMO ignoring the option is ok if it didn't work previously anyway. Would it be reasonable to a warning on stderr, too?

[levitte]

It's been ignored since July 2015, as off 0bc2f36

So basically, the last time it was at all used was with 1.0.2

[levitte]

BTW, this doesn't break anything in 1.1.1, it's already broken in this respect (and [ahem] hilariously so, I might add):

: ; ./util/shlib_wrap.sh openssl rsa -in ../1.1.1/test/testrsa.pem -out foo.ns -outform netscape
rsa: Bad format "netscape"; must be one of:
   PEM/DER
   pkcs12
   smime
   engine
   msblob
   netscape
   nss
   text
   http
   pvk
rsa: Invalid format "netscape" for -outform
rsa: Use -help for summary.
: ; ./util/shlib_wrap.sh openssl rsa -in ../1.1.1/test/testrsa.pem -out foo.ns -outform net
rsa: Bad format "net"; must be one of:
   PEM/DER
   pkcs12
   smime
   engine
   msblob
   netscape
   nss
   text
   http
   pvk
rsa: Invalid format "net" for -outform
rsa: Use -help for summary.

So I still think this should be cherry-picked back to 1.1.1.

[mspncp]

Replacing a failure by a more sensible failure is not a regression, it's a bugfix. So in this case, go ahead to cherry-pick it, if @paulidale approves.

[levitte]

@paulidale, after the deliberation here, do you approve cherry-picking back to 1.1.1?

[paulidale]

Yes, 1.1.1 is good too. Broken is broken and I don't mind why.

[levitte]

Merged.

master:
d91d443 apps: Stop pretending to care about Netscape keys

1.1.1:
b33e769 apps: Stop pretending to care about Netscape keys