Rework and simplify resource flow in drbg_add #7504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernd-edlinger
added
branch: master
|
Thanks, I'll have a look. But let me tie up some other loose ends first. Currently my resources are limited due to family affairs... |
mspncp
approved these changes
Oct 28, 2018
There was a problem hiding this comment.
You are right, things make much more sense if the lifetime of the drbg->pool is managed by a single function, in this case rand_drbg_restart(). Also, my idea to use drbg->pool != NULL as an indicator for what happened with the random data was a mistake and an unnecessary complication. With your approach, the undefinedness problem has naturally disappeared.
mspncp
added
the
approval: review pending
paulidale
approved these changes
Oct 29, 2018
paulidale
added
approval: done
levitte
pushed a commit
that referenced
this pull request
Oct 29, 2018
Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> Reviewed-by: Paul Dale <paul.dale@oracle.com> (Merged from #7504)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a bug fix, but making things a lot easier to understand (I hope).