ERR: preserve system error number in a few more places #7902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that intialization may change the error number, so we need to preserve the system error number in functions where initialization is called for. These are ERR_get_state() and err_shelve_state() Fixes openssl#7897
levitte
added
branch: master
|
@mshaw1990, if you would test the changes here, that would be great. They should be cherry-pickable to the 1.1.1 branch, if you prefer that. |
levitte
changed the title
|
I'm marking this WorkInProgress until having received confirmation from @mshaw1990 that this solves #7897 |
|
I downloaded commit ee80f4b and the test now passes! |
mattcaswell
approved these changes
Dec 14, 2018
levitte
changed the title
|
Cool. Thanks for trying it out! |
levitte
added
the
approval: done
levitte
added a commit
that referenced
this pull request
Dec 14, 2018
It turns out that intialization may change the error number, so we need to preserve the system error number in functions where initialization is called for. These are ERR_get_state() and err_shelve_state() Fixes #7897 Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #7902) (cherry picked from commit 91c5473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that initialization may change the error number, so we
need to preserve the system error number in functions where
initialization is called for.
These are ERR_get_state() and err_shelve_state()
Fixes #7897