Move ASN1_BROKEN macros #8302
Closed
Move ASN1_BROKEN macros #8302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That moves it away from a public header. Do you know for a fact that no one else uses it? |
|
(... or that it's extremely unlikely... that's much more subjective, though) |
|
Yes, I know for sure that absolutely nobody anywhere in the world is using this macro. No, of course not. But do this PR early and it's trivial to revert. Shrug. |
InfoHunter
approved these changes
Feb 22, 2019
InfoHunter
added
approval: done
They're only used in one place, and only for a legacy datatype.
|
@levitte and/or @InfoHunter can this be merged? |
|
Merged. 6098b69 Move ASN1_BROKEN macros |
levitte
pushed a commit
that referenced
this pull request
Mar 19, 2019
They're only used in one place, and only for a legacy datatype. Reviewed-by: Paul Yang <yang.yang@baishancloud.com> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #8302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're only used in one place, and only for a legacy datatype.
This is useful for upcoming FIPS work which needs to implement "just enough" ASN1 stuff.