Added NULL check to BN_clear() & BN_CTX_end() #8518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it worthwhile making this change in 1.1.1 too? Just to keep the code more in sync. |
paulidale
approved these changes
Mar 19, 2019
paulidale
added
the
approval: review pending
I agree. Thus later patches using these functions will be consistent when they are being ported back to 1.1.1 |
levitte
approved these changes
Mar 19, 2019
levitte
added
approval: done
levitte
pushed a commit
that referenced
this pull request
Mar 19, 2019
Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #8518)
|
Very nice. Now do a PR to update the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BN_clear_free & BN_CTX_free() both do a NULL check, so it makes sense to also do the NULL
check inside BN_clear() and BN_CTX_end() since these are commonly called at the end of a function in a similar location to the free calls.
BN_clear() is only used in new code so this is not much of a change.
BN_CTX_end() is commonly called before BN_CTX_free() and quite often already does the NULL check
(so moving it inside the function should not be too much overhead). The normal case is that it is not NULL so calling the function is normally required.
This cleanup addresses quite a few coverity issues (in RSA code related to both BN_clear & BN_CTX_end)
Checklist