New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conn_is_closed should return 1 if get_last_sys_error is WSAECONNRESET #8590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is trivial
@paulmon please can you amend your commit message to include the "CLA: trivial" text in the commit description (to keep the CLA bot happy). |
I tried editing the commit message with git --amend, but the buildbot still doesn't like it. |
Close/reopen to kick CLA bot |
Not sure why the bot doesn't like it. It looks ok to me. I removed it by hand for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that this is trivial.
CLA: trivial Reviewed-by: Paul Dale <paul.dale@oracle.com> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #8590)
Pushed. Thanks. |
CLA: trivial
conn_is_closed should check for WSAECONNRESET on Windows because it has a different value than ECONNRESET. Without this check ssl tests fail in the Python standard tests because the SSL_do_handshake() on the server side returns an error if the client closes the socket too quickly.