Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed public range check in ec_GF2m_simple_oct2point #8607

Closed
wants to merge 1 commit into from

Conversation

slontis
Copy link
Member

@slontis slontis commented Mar 28, 2019

This issue was raised when fixing the ec key validation by @davidben. The same check is now done by the public key when it is loaded (which uses the oct2point method).

Checklist
  • documentation is added or updated
  • tests are added or updated

@slontis slontis mentioned this pull request Mar 28, 2019
2 tasks
@bernd-edlinger bernd-edlinger added branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch 3.0.0 labels Mar 29, 2019
Copy link
Member

@bernd-edlinger bernd-edlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for all branches

@bernd-edlinger bernd-edlinger added branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch 1.1.0 labels Mar 29, 2019
@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Mar 29, 2019
levitte pushed a commit that referenced this pull request Mar 30, 2019
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from #8607)
levitte pushed a commit that referenced this pull request Mar 30, 2019
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from #8607)

(cherry picked from commit cad8347)
levitte pushed a commit that referenced this pull request Mar 30, 2019
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from #8607)

(cherry picked from commit cad8347)
levitte pushed a commit that referenced this pull request Mar 30, 2019
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from #8607)

(cherry picked from commit cad8347)
@bernd-edlinger
Copy link
Member

Merged to master as cad8347
Merged to 1.1.1 as 73ab470
Merged to 1.1.0 as 3b5a079 (omitting test case)
Merged to 1.0.2 as d3299a3 (omitting test case)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: 1.0.2 Merge to OpenSSL_1_0_2-stable branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants