Configure: let platform->dsoext() default with platform->shlibextsimple() #8951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le() We still use '.so' as a last resort... Fixes openssl#8950
chipitsine
approved these changes
May 19, 2019
|
Note that this restores the behaviour that 1.1.1 and older have |
|
I'm ok with that |
|
Yes... that was rather a comment to the @openssl team, in case they would wonder ('cause they will have to make the final and deciding approval) |
t-j-h
approved these changes
May 19, 2019
|
Merged. d3136af Configure: let platform->dsoext() default with platform->shlibextsimple() |
chipitsine
added a commit
to chipitsine/engine
that referenced
this pull request
May 20, 2019
we do not need to copy "dylib" to "so" after openssl/openssl#8951
|
I've only just seen this and have currently no means to check for real. But if I understand the change correctly, it would mean that the DSOs now get |
|
In that case, |
|
Proposed fix in #9005 |
chipitsine
added a commit
to chipitsine/engine
that referenced
this pull request
Jun 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still use '.so' as a last resort...
Fixes #8950