Put symhacks in crypto.h; dont edit generated file. [1.1.1] #9281
Conversation
This does no harm, and ensures that the inclusion isn't mistakenly removed in the generated *err.h where it's actually needed. Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from openssl#8397) (cherry picked from commit b53c4fe)
| @@ -455,6 +453,10 @@ sub help | |||
| #ifndef HEADER_${lib}ERR_H | |||
| # define HEADER_${lib}ERR_H | |||
|
|
|||
| # ifndef HEADER_SYMHACKS_H | |||
There was a problem hiding this comment.
I still wonder why this guard is necessary...
There was a problem hiding this comment.
It's an optimization: these 'external' include guards have the advantage that the compiler (resp. preprocessor) does not need to open and read the entire file over and over again when it's included repeatedly. In the modern days where computers have plenty of RAM and efficient file caching, this optimization might not be so important anymore, but still it might speed up compilation.
Unfortunately, there is still no standardized way to tell the compiler that an include file should be included only once, although most of the modern compilers understand #pragma once, which is most often used in conjunction with normal include guards for portability reasons.
Anyway, this question comes too late for this pull request, since it's only a backport of an already merged pr. If you want the external include guards removed, it would have to be done in a separate pull request.
This does no harm, and ensures that the inclusion isn't mistakenly removed in the generated *err.h where it's actually needed. Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit b53c4fe) Reviewed-by: Matthias St. Pierre <Matthias.St.Pierre@ncp-e.com> (Merged from #9281)
Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com> (Merged from #9281)
This is a delayed backport of #8397 to 1.1.1 (see #8397 (comment)).