Remove externally used include guards [1.1.1] #9365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This include guard inside an object file comes as a surprise and serves no purpose anymore. It seems like this object file was included by crypto/threads/mttest.c at some time, but the include directive was removed in commit bb8abd6.
The check is redundant, because <openssl/x509v3.h> is included.
The HEADER_X509_H check is redundant, because <openssl/x509.h> is already included.
mspncp
force-pushed
the
pr-remove-externally-used-include-guards-111
branch
from
25ee615
to
a7cc91d
Compare
Move _kbhit() from s_apps.h to apps.c
mspncp
force-pushed
the
pr-remove-externally-used-include-guards-111
branch
from
a7cc91d
to
7cec6f7
Compare
Fix preprocessor indentation
mspncp
added
the
approval: review pending
bernd-edlinger
approved these changes
Jul 24, 2019
|
ping @levitte? |
levitte
approved these changes
Jul 24, 2019
|
Sorry I took some time. As you may have seen, I have quite a set of distractions 😉 |
|
Yes, I know that you are very busy currently. And I appreciate that you took the time to look. |
mspncp
added
approval: done
levitte
pushed a commit
that referenced
this pull request
Jul 24, 2019
Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from #9365)
levitte
pushed a commit
that referenced
this pull request
Jul 24, 2019
This include guard inside an object file comes as a surprise and serves no purpose anymore. It seems like this object file was included by crypto/threads/mttest.c at some time, but the include directive was removed in commit bb8abd6. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from #9365)
levitte
pushed a commit
that referenced
this pull request
Jul 24, 2019
The check is redundant, because <openssl/x509v3.h> is included. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from #9365)
levitte
pushed a commit
that referenced
this pull request
Jul 24, 2019
The HEADER_X509_H check is redundant, because <openssl/x509.h> is already included. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de> (Merged from #9365)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of pull request #9364 to 1.1.1
The only commit which had some minor conflicts is the last commit
The conflict was caused by reorganization of the internal app headers between 1.1.1 and master.
It has a fixup because of a compiler warning (as error) about
_kbhit().