Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DRBG from SSL structure. #9390

Closed
wants to merge 1 commit into from
Closed

Remove DRBG from SSL structure. #9390

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

The field is unused.

t-j-h
t-j-h approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@t-j-h t-j-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange that the commit that introduced this into the structure didn't use it.

levitte pushed a commit that referenced this pull request Jul 16, 2019
@paulidale
Remove DRBG from SSL structure.
3d9b33b 
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #9390)
@paulidale paulidale added branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch branch: master Merge to master branch labels Jul 16, 2019
@paulidale
Copy link
Contributor Author

It is a bit strange. Merged to master.
I'll assume 1.1.1 as well since it's the same.

@t-j-h
Copy link
Member

t-j-h commented Jul 16, 2019

Indeed. Remove where ever it is sitting their unused.

levitte pushed a commit that referenced this pull request Jul 16, 2019
@paulidale
Remove DRBG from SSL structure.
cf8b373 
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #9390)

(cherry picked from commit 3d9b33b)
@paulidale
Copy link
Contributor Author

And done.

@paulidale paulidale closed this Jul 16, 2019
@paulidale paulidale deleted the ssl-drbg branch July 16, 2019 03:28
@mspncp
Copy link
Contributor

mspncp commented Jul 16, 2019

It is strange that the commit that introduced this into the structure didn't use it.

FWIW: per-ssl DRBGs were used at some time, but it turned out that per-thread DRBGs are a better alternative, so they were removed in 16cfc2c as part of #5547.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-j-h t-j-h t-j-h approved these changes

Assignees
No one assigned
Labels
branch: master Merge to master branch branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulidale @t-j-h @mspncp