Adapt DH to use with KEYMGMT #9394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
force-pushed
the
evp_keymgmt-dh
branch
2 times, most recently
from
09a9fdb
to
7905081
Compare
mattcaswell
requested changes
Jul 16, 2019
levitte
force-pushed
the
evp_keymgmt-dh
branch
4 times, most recently
from
464aa2f
to
3b0f8a1
Compare
mattcaswell
requested changes
Jul 19, 2019
levitte
force-pushed
the
evp_keymgmt-dh
branch
3 times, most recently
from
bb7fd1e
to
e224638
Compare
|
Now that #9312 has been merged, it's time to take this out of WIP |
levitte
changed the title
|
Needs a rebase |
|
Rebase done |
|
Rebased, again |
paulidale
reviewed
Jul 23, 2019
mattcaswell
requested changes
Jul 23, 2019
mattcaswell
approved these changes
Jul 23, 2019
|
Rebased. Only an adjustment of |
|
Reconfirm assuming CIs pass. |
The biggest part in this was to move the key->param builder from EVP to the DH ASN.1 method, and to implement the KEYMGMT support in the provider DH.
|
An empty line at the end of |
|
Ok! Time to merge |
|
Merged. 8b84b07 Adapt DH to use with KEYMGMT |
levitte
added a commit
that referenced
this pull request
Jul 23, 2019
The biggest part in this was to move the key->param builder from EVP to the DH ASN.1 method, and to implement the KEYMGMT support in the provider DH. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #9394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest part in this was to move the key->param builder from EVP
to the DH ASN.1 method, and to implement the KEYMGMT support in the
provider DH.