Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL_CTX_get_ciphers() #957

Closed
wants to merge 1 commit into from

Conversation

rhenium
Copy link
Contributor

@rhenium rhenium commented Apr 10, 2016

There are both set/get functions for SSL:

int SSL_set_cipher_list(SSL *s, const char *str);
STACK_OF(SSL_CIPHER) *SSL_get_ciphers(const SSL *s);

But for SSL_CTX, there is only set function:

int SSL_CTX_set_cipher_list(SSL_CTX *ctx, const char *str);

and currently no get function:

STACK_OF(SSL_CIPHER) *SSL_CTX_get_ciphers(const SSL_CTX *ctx);

Since libssl was made opaque, there is no way for users to access SSL_CTX.cipher_list, so I think it should be implemented.

Thanks,

Add an accessor for SSL_CTX.

Since libssl was made opaque, there is no way for users to access the
cipher_list, while users can set the cipher_list by
SSL_CTX_set_cipher_list().
@richsalz richsalz self-assigned this Apr 11, 2016
@richsalz
Copy link
Contributor

@mattcaswell can you plus-one? This is a nice complete patch that adds missing opaque-required accessors.
+1

@mattcaswell
Copy link
Member

+1

@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Apr 11, 2016
@richsalz
Copy link
Contributor

merged, thanks! Nice patch!

@richsalz richsalz closed this Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants