Fix 9bf682f which broke nistp224_method #9607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"make update" is also broken. Any chance of adding #9600 to this PR? Or getting rapid approval for it, with this one? |
|
#9600 is in now, it deserves a rebase. |
slontis
approved these changes
Aug 16, 2019
levitte
approved these changes
Aug 16, 2019
Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com>
p-steuer
added
the
approval: done
levitte
pushed a commit
that referenced
this pull request
Aug 16, 2019
Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #9607)
|
pushed to master: 653b883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@richsalz noticed that PR #9348 (comment) introduced an error.
I assume it must have happened during one of the rebases. I only wonder why i neither see the warning with gcc (--strict-warnings enabled) nor the test suite failed (the p224 code is enabled per default, no?) ..