Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bignum static constants instead of BN_bin2bn() #982

Closed
wants to merge 2 commits into from

Conversation

huangqinjin
Copy link
Contributor

keep consistent with bn_dh.c bn_nist.c bn_srp.c

@richsalz
Copy link
Contributor

rather than cut/paste and duplicate the bn_pack macros, they should be put into one place in bn_lcl.h and used everywhere consistently.

@@ -2,6 +2,7 @@

#include <openssl/bn.h>

#if 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why #if 0 the old code out rather than just deleting it?

@huangqinjin
Copy link
Contributor Author

@richsalz bn_srp.c defined the bn_pack4 macro, but I think bn_pack2 marco should work well. How to make them consistent and then put into bn_lcl.h.This is my first try to contribute to openssl, so any word helps me. Thank you.

@richsalz
Copy link
Contributor

Post to openssl-dev; good questions.

@huangqinjin huangqinjin deleted the dev branch April 21, 2016 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants