Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Requirements Policy #40

Closed
wants to merge 9 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Apr 5, 2022

This adds the policy that covers general requirements that must be met before we create a release (alpha/beta/stable).

It also describes the issue and pull request triage process in short.

@t8m t8m added the policy change A change to a policy is being proposed label Apr 5, 2022
@t8m
Copy link
Member Author

t8m commented Apr 5, 2022

Fixes #22

policies/release-requirements.md Outdated Show resolved Hide resolved
policies/release-requirements.md Show resolved Hide resolved
policies/release-requirements.md Outdated Show resolved Hide resolved
policies/release-requirements.md Outdated Show resolved Hide resolved
policies/release-requirements.md Outdated Show resolved Hide resolved
@t8m
Copy link
Member Author

t8m commented Apr 7, 2022

@mattcaswell fixup pushed addressing your comments.

policies/release-requirements.md Outdated Show resolved Hide resolved
policies/release-requirements.md Outdated Show resolved Hide resolved
policies/release-requirements.md Outdated Show resolved Hide resolved
policies/release-requirements.md Outdated Show resolved Hide resolved
@t8m
Copy link
Member Author

t8m commented May 3, 2022

Updated to deal with some/most? of the comments from the OTC discussion. Please re-review.

policies/release-requirements.md Show resolved Hide resolved
policies/release-requirements.md Show resolved Hide resolved
policies/release-requirements.md Outdated Show resolved Hide resolved
@t8m t8m added the discussed The issue/pr was discussed by the OTC label May 10, 2022
@t8m
Copy link
Member Author

t8m commented May 11, 2022

Based on the OTC discussion we had yesterday, I've added a separate Patch releases section. I've also simplified and removed some duplications and moved some things to the Triage process section.

@t8m
Copy link
Member Author

t8m commented May 11, 2022

@openssl/otc please re-review as I plan to start a vote soon.

regression or security fixes should be merged during the freeze.
- For 2 days before the release there should be no changes to ensure the daily
CI builds run on the development tree tip.
- Embargoed security fixes are excepted from the rule above as they cannot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there more steps associated with security patches (CVE's and notifications)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO they should not belong here as they would confuse things. If we have any security release process policy, it should be there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still sounds like Release requirements to me..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I beg to differ.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to do the security release these are requirements - It could be a link to another document...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can/should do that later.

policies/release-requirements.md Outdated Show resolved Hide resolved
@t8m t8m added the ready to vote The policy change proposal is ready to be voted on by the OTC label May 25, 2022
@t8m
Copy link
Member Author

t8m commented May 25, 2022

Starting the vote for Add Release Requirements Policy at commit 1845646

@t8m
Copy link
Member Author

t8m commented May 25, 2022

Vote: [+1]

6 similar comments
@mattcaswell
Copy link
Member

Vote: [+1]

@beldmit
Copy link
Member

beldmit commented May 25, 2022

Vote: [+1]

@romen
Copy link
Member

romen commented May 25, 2022

Vote: [+1]

@slontis
Copy link
Member

slontis commented May 25, 2022

Vote: [+1]

@t-j-h
Copy link
Member

t-j-h commented May 25, 2022

Vote: [+1]

@paulidale
Copy link
Contributor

Vote: [+1]

- The OTC should explicitly approve that the source is ready for a release with
a vote.

Patch Releases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be noted that we have also call these "release updates", see policies/stable-release-updates.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if we want to change the nomenclature to "patch releases", we should probably do that across the board... but still leave a note somewhere saying what we used to call it, to connect the dots. Frankly, I'd welcome such a change, since "patch release" is a broadly used term)

@t8m
Copy link
Member Author

t8m commented May 31, 2022

@levitte @kroeckx ping for vote

@levitte
Copy link
Member

levitte commented May 31, 2022

@levitte @kroeckx ping for vote

As soon as someone answers my question (see review comment)
ARGH never mind, wrong PR

@levitte
Copy link
Member

levitte commented May 31, 2022

Vote: [+1]

1 similar comment
@mspncp
Copy link
Contributor

mspncp commented May 31, 2022

Vote: [+1]

bug is a regression or not.

In general regressions should be fixed as soon as possible, optimally before
the next release from the development tree is done. However sometimes that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me what you mean with development tree. I suggest you make it: "before the next release is done"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late. The vote has started.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can always create an other PR to fix that.

an OTC member according to what is the type (feature, bug, documentation,
refactoring, ...) of the issue or pull request. When the triage happens for an
issue or pull request that is a bug/bug fix, it must be assessed whether the
bug is a regression or not.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we mark something as regression? Do we just assign it milestones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a label: severity: regression.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this policy should be more clear about such labels.

@kroeckx
Copy link
Member

kroeckx commented Jun 6, 2022

Voting +1

@t8m
Copy link
Member Author

t8m commented Jun 6, 2022

Closing the vote.

Topic: Add Release Requirements Policy at commit 1845646
       This will become an official OTC policy.
Proposed by: Tomas
Issue link: https://github.com/openssl/technical-policies/pull/40
Public: yes
Opened: 2022-05-25
Closed: 2022-06-06
Accepted: yes   (for: 10, against: 0, abstained: 0, not voted: 0)

   Dmitry     [+1]
   Matt       [+1]
   Pauli      [+1]
   Tim        [+1]
   Richard    [+1]
   Shane      [+1]
   Tomas      [+1]
   Kurt       [+1]
   Matthias   [+1]
   Nicola     [+1]

@t8m t8m closed this Jun 6, 2022
@t8m t8m added accepted The policy change proposal was accepted by an OTC vote and removed ready to vote The policy change proposal is ready to be voted on by the OTC labels Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The policy change proposal was accepted by an OTC vote discussed The issue/pr was discussed by the OTC policy change A change to a policy is being proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet