Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a process for minor policy edits #42

Closed
wants to merge 5 commits into from
Closed

Add a process for minor policy edits #42

wants to merge 5 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Apr 11, 2022

This adds simple process for minor policy edits as an exception to the policy change process.

Alternative to #36

@t8m t8m added the policy change A change to a policy is being proposed label Apr 11, 2022
mattcaswell
mattcaswell reviewed Apr 11, 2022
View reviewed changes
policies/policy-change-process.md

These edits are done via pull requests that are approved by two OTC members
where neither of them is the author of the submission. The pull request
should be labelled with the `minor edit` label.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should both members have to explicitly agree to that the normal process does not need to be followed. Or is the label and 24 hour timer sufficient?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the latter. We do this for branches on the main repo, why not here too?
CLA: trivial does it the opposite way around...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often forget about the need to explicitly agree on things and I believe the less bureaucracy and comment spam the better. So in my opinion, 2 approvals and label and 24h period is sufficient.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we decide last week? to change should be labelled to must be labelled?

But never mind, that's no show-stopper.

levitte
levitte reviewed Apr 14, 2022
View reviewed changes
policies/policy-change-process.md
This policy represents the way that any additions or changes to the existing
policies are proposed, edited, finalized, and approved.
This policy represents the way that any additions or changes to the
existing policies are proposed, edited, finalized, and approved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the edit was a little unnecessary...

@t8m t8m mentioned this pull request Apr 14, 2022
Closed
beldmit
beldmit approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t8m t8m added discussed The issue/pr was discussed by the OTC ready to vote The policy change proposal is ready to be voted on by the OTC labels Apr 26, 2022
@t8m
Copy link
Member Author

t8m commented May 3, 2022

Vote for accepting the process for minor policy edits at commit 4d65590 has started.

@t8m
Copy link
Member Author

t8m commented May 3, 2022

Vote: [+1]

@slontis
Copy link
Member

slontis commented May 3, 2022

Vote: [+1]

4 similar comments
@paulidale
Copy link
Contributor

Vote: [+1]

@beldmit
Copy link
Member

beldmit commented May 3, 2022

Vote: [+1]

@t-j-h
Copy link
Member

t-j-h commented May 3, 2022

Vote: [+1]

@mattcaswell
Copy link
Member

Vote: [+1]

@levitte
Copy link
Member

levitte commented May 3, 2022

vote: [+1]

@mspncp
Copy link
Contributor

mspncp commented May 3, 2022

Vote: [+1]

@t8m
Copy link
Member Author

t8m commented May 6, 2022

ping @romen @kroeckx for votes, if you want to vote

@kroeckx
Copy link
Member

kroeckx commented May 7, 2022

Voting +1

@romen
Copy link
Member

romen commented May 17, 2022

Vote: [+1]

@t8m
Copy link
Member Author

t8m commented May 17, 2022 

Topic: Add a process for minor policy edits at commit 4d65590
       This will become an official OTC policy.
Proposed by: Tomas
Issue link: https://github.com/openssl/technical-policies/pull/42
Public: yes
Opened: 2022-05-03
Closed: 2022-05-17
Accepted: yes   (for: 10, against: 0, abstained: 0, not voted: 0)

   Dmitry     [+1]
   Matt       [+1]
   Pauli      [+1]
   Tim        [+1]
   Richard    [+1]
   Shane      [+1]
   Tomas      [+1]
   Kurt       [+1]
   Matthias   [+1]
   Nicola     [+1]

@t8m t8m closed this May 17, 2022
@t8m t8m added accepted The policy change proposal was accepted by an OTC vote and removed ready to vote The policy change proposal is ready to be voted on by the OTC labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte left review comments

@mattcaswell mattcaswell mattcaswell left review comments

@mspncp mspncp mspncp left review comments

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
accepted The policy change proposal was accepted by an OTC vote discussed The issue/pr was discussed by the OTC policy change A change to a policy is being proposed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@t8m @slontis @paulidale @beldmit @t-j-h @mattcaswell @levitte @mspncp @kroeckx @romen