Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coding-style.md: add various rules for writing C expressions - r2 #46

Closed
wants to merge 5 commits into from
Closed

coding-style.md: add various rules for writing C expressions - r2 #46

wants to merge 5 commits into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented May 4, 2022

This is a revision of #39, which failed to pass the voting due to partly ambiguous texts and late comments about this.

Note that the fixup commit 254439f contains the two changes proposed today.

levitte
levitte reviewed May 4, 2022
View reviewed changes
policies/coding-style.md Outdated Show resolved Hide resolved
@DDvO DDvO mentioned this pull request May 4, 2022
Open
@DDvO DDvO changed the title coding-style.md: add various rules for writing C expressions - r2 coding-style.md: add various rules for writing C expressions - r2 May 4, 2022
paulidale
paulidale requested changes May 5, 2022
View reviewed changes
policies/coding-style.md Outdated Show resolved Hide resolved
policies/coding-style.md Outdated Show resolved Hide resolved
policies/coding-style.md Show resolved Hide resolved
@DDvO DDvO requested a review from paulidale May 5, 2022 06:39
t8m
t8m requested changes May 5, 2022
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo

policies/coding-style.md Outdated Show resolved Hide resolved
@t8m t8m added the policy change A change to a policy is being proposed label May 5, 2022
@DDvO
Copy link
Contributor Author

DDvO commented May 9, 2022 •
edited

Thanks for the further discussion and approvals, also regarding the related PRs #47 and #48.

What does the formal process require now?
Has the new 14-days waiting period already started on them, after which the OTC votings can be (re-)done?

@t8m
Copy link
Member

t8m commented May 9, 2022

Has the new 14-days waiting period already started on them, after which the OTC votings can be (re-)done?

Yes, that period starts when the PR is submitted.

@t8m t8m added the discussed The issue/pr was discussed by the OTC label May 10, 2022
@t8m
Copy link
Member

t8m commented May 18, 2022

Starting the vote for coding-style.md: add various rules for writing C expressions - r2 at commit 2dc5c2b

@t8m t8m added the ready to vote The policy change proposal is ready to be voted on by the OTC label May 18, 2022
@t8m
Copy link
Member

t8m commented May 18, 2022

Vote: [+1]

2 similar comments
@paulidale
Copy link
Contributor

Vote: [+1]

@beldmit
Copy link
Member

beldmit commented May 18, 2022

Vote: [+1]

@t-j-h
Copy link
Member

t-j-h commented May 18, 2022

Vote: [0]

@mattcaswell
Copy link
Member

Vote: [+1]

1 similar comment
@slontis
Copy link
Member

slontis commented May 18, 2022

Vote: [+1]

@romen
Copy link
Member

romen commented May 24, 2022

Vote: [+0]

@t8m
Copy link
Member

t8m commented May 25, 2022

@levitte @mspncp @kroeckx last call for votes 😁

@kroeckx
Copy link
Member

kroeckx commented May 30, 2022

Voting +1

@levitte
Copy link
Member

levitte commented May 31, 2022

Vote: [+1]

@t8m t8m added accepted The policy change proposal was accepted by an OTC vote and removed ready to vote The policy change proposal is ready to be voted on by the OTC labels May 31, 2022
@t8m
Copy link
Member

t8m commented May 31, 2022

Closing the vote now.

Topic: coding-style.md: add various rules for writing C expressions -
r2 at commit 2dc5c2b 
       This will become an official OTC policy.
Proposed by: Tomas
Issue link: https://github.com/openssl/technical-policies/pull/46
Public: yes
Opened: 2022-05-18
Closed: 2022-05-31
Accepted: yes   (for: 7, against: 0, abstained: 2, not voted: 1)

   Dmitry     [+1]
   Matt       [+1]
   Pauli      [+1]
   Tim        [ 0]
   Richard    [+1]
   Shane      [+1]
   Tomas      [+1]
   Kurt       [+1]
   Matthias   [  ]
   Nicola     [+0]

@t8m t8m closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte left review comments

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
accepted The policy change proposal was accepted by an OTC vote discussed The issue/pr was discussed by the OTC policy change A change to a policy is being proposed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@DDvO @t8m @paulidale @beldmit @t-j-h @mattcaswell @slontis @romen @kroeckx @levitte