Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run run-checker with GOST test switched on #21

Closed
mattcaswell opened this issue Jul 13, 2018 · 4 comments
Closed

Run run-checker with GOST test switched on #21

mattcaswell opened this issue Jul 13, 2018 · 4 comments

Comments

@mattcaswell
Copy link
Member

Now that openssl/openssl#6650 has been merged we have a test capable of testing GOST ciphersuites if a GOST engine in present. The test requires that the environment variable OPENSSL_GOST_ENGINE_SO is set to point at gost.so. We should set up run-checker so that this is configured.

@mattcaswell
Copy link
Member Author

Ping @levitte.

@levitte
Copy link
Member

levitte commented Jul 14, 2018

Uhmmmmm... I should have looked more closely at openssl/openssl#6650 when I had the chance.
Is there a reason the test wasn't implemented as an external alongside the bunch of 95 series tests we already have? Building the GOST engine automatically as part of the test should be quite easy, as far as I can tell.

@mattcaswell
Copy link
Member Author

Is there a reason the test wasn't implemented as an external alongside the bunch of 95 series tests we already have?

Well, I didn't really view it as an external test. This is not about running tests provided by others as part of our test suite. This is running a test that we have written to test functionality in libssl. It's more along the lines of an external dependency (e.g. such as libz) which you need to have present in order to activate certain functions.

Since GOST is on by default this test will be run every time if the GOST engine is available. I'm not sure we necessarily want to build the engine every time we do a build. I more envisaged that it would be present on the run-checker box in compiled form that we could update from time to time.

@levitte
Copy link
Member

levitte commented Jul 14, 2018

Yeahok... I can see the benefit with that.

levitte added a commit to levitte/openssl-tools that referenced this issue Jul 14, 2018
It gets built against a 1.1.0 build, on purpose to check that it links
and runs correctly against any libcrypto.so.1.1.

Fixes openssl#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants