Tool changes for Mac OS/X. #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perl ends up with a different path when installed using _brew_. The system perl seems to have broken _cpan_ somehow. Some additional packages need to be installed. PATH also needs to be set so it can find the _plackup_ executable.
levitte
requested changes
Nov 18, 2018
| @@ -23,6 +23,8 @@ OpenSSL::Query requires these extra modules to run: | |||
| - Class::Method::Modifiers (debian package libclass-method-modifiers-perl) | |||
| - Moo (debian package libmoo-perl) | |||
| - URI::Encode (debian package liburi-encode-perl) | |||
| - LWP::UserAgent | |||
| - LWP::Protocol::https | |||
There was a problem hiding this comment.
Please change the "requires" section in Makefile.PL as well
There was a problem hiding this comment.
Added.
I'm not au fait with Perl.
There was a problem hiding this comment.
I've updated the required section (I think).
|
PS: you shouldn't be working on a Sunday :( |
levitte
pushed a commit
that referenced
this pull request
Nov 19, 2018
Perl ends up with a different path when installed using _brew_. The system perl seems to have broken _cpan_ somehow. Some additional packages need to be installed. PATH also needs to be set so it can find the _plackup_ executable. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #35)
levitte
pushed a commit
that referenced
this pull request
Nov 19, 2018
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from #35)
levitte
pushed a commit
to openssl/omc-tools
that referenced
this pull request
Apr 23, 2020
Perl ends up with a different path when installed using _brew_. The system perl seems to have broken _cpan_ somehow. Some additional packages need to be installed. PATH also needs to be set so it can find the _plackup_ executable. Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from openssl/tools#35)
levitte
pushed a commit
to openssl/omc-tools
that referenced
this pull request
Apr 23, 2020
Reviewed-by: Richard Levitte <levitte@openssl.org> (Merged from openssl/tools#35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl ends up with a different path when installed using brew. The system perl
seems to have broken cpan somehow.
Some additional packages need to be installed.
PATH also needs to be set so it can find the plackup executable.