Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-checker: Check enabling and disabling trace #37

Closed
wants to merge 2 commits into from
Closed

run-checker: Check enabling and disabling trace #37

wants to merge 2 commits into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Mar 14, 2019

No description provided.

@levitte levitte mentioned this pull request Mar 14, 2019
Closed
mspncp
mspncp reviewed Mar 14, 2019
View reviewed changes
Copy link
Contributor

@mspncp mspncp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why both? For all other options, only the non-default is specified.

@InfoHunter
Copy link
Member

What is the default behaviour of trace?

@mspncp
Copy link
Contributor

mspncp commented Mar 14, 2019

It’s currently changing from enabled to disabled, see #8474.

@levitte
Copy link
Member Author

levitte commented Mar 15, 2019 •
edited

It's precisely because we're currently in a state of fluctuation that I made it both.

(side note: when linking to pull requests in a different repo, you have to be a little more verbose: openssl/openssl#8474)

@mspncp
Copy link
Contributor

mspncp commented Mar 15, 2019

Thanks, I know. But I was doing it on my mobile (once again), so I was too lazy :P

@mspncp
Copy link
Contributor

mspncp commented Mar 15, 2019

It's precisely because we're currently in a state of fluctuation that I made it both.

Since openssl/openssl#8474 has been merged meanwhile, I'd prefer having only the non-default now.

@levitte
Copy link
Member Author

levitte commented Mar 15, 2019

Sure

levitte added a commit that referenced this pull request May 13, 2019
@levitte
run-checker: Check enabling and disabling trace
31b2767 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #37)
@levitte
Copy link
Member Author

levitte commented May 13, 2019

Merged.

31b2767 run-checker: Check enabling and disabling trace

@levitte levitte closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspncp mspncp mspncp left review comments

@InfoHunter InfoHunter InfoHunter approved these changes

@t-j-h t-j-h t-j-h approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@levitte @InfoHunter @mspncp @t-j-h @mattcaswell