Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL300Design: lighten watermark #127

Closed

Conversation

mspncp
Copy link
Contributor

@mspncp mspncp commented Mar 15, 2019

The strong DRAFT watermark is very distracting while reading and makes
the eyes loose the current reading position while scrolling.

Noticed while reading https://www.openssl.org/docs/OpenSSL300Design.html

@t-j-h
Copy link
Member

t-j-h commented Mar 15, 2019

Isn't that heading in the opposite direction to what you want?

@t-j-h
Copy link
Member

t-j-h commented Mar 15, 2019

i.e. 0.1 to 0.25 is making it darker, 0.1 to 0.05 would make it lighter

@t-j-h t-j-h closed this Mar 15, 2019
@t-j-h t-j-h reopened this Mar 15, 2019
@mspncp
Copy link
Contributor Author

mspncp commented Mar 15, 2019

Isn't that heading in the opposite direction to what you want?

I determined the value by experimenting directly with https://www.openssl.org/docs/OpenSSL300Design.html in the Chrome developer tool. It's an alpha value I guess.

@mspncp
Copy link
Contributor Author

mspncp commented Mar 15, 2019

So less alpha makes the white background shine through more, i.e. makes it lighter.

@mspncp
Copy link
Contributor Author

mspncp commented Mar 15, 2019

Oh sorry, now I see my mistake: I intended to change 0.1 to 0.025.

@mspncp
Copy link
Contributor Author

mspncp commented Mar 15, 2019

And sorry for explaining trivialities to you :-)

@mspncp mspncp force-pushed the pr-ossl300design-lighten-watermark branch from 1f626ce to 71987b0 Compare March 15, 2019 01:14
@mspncp
Copy link
Contributor Author

mspncp commented Mar 15, 2019

Fixed.

The strong DRAFT watermark is very distracting while reading and makes
the eyes loose the current reading position while scrolling.
@mspncp mspncp force-pushed the pr-ossl300design-lighten-watermark branch from 71987b0 to 6f394e3 Compare March 15, 2019 01:15
@t-j-h
Copy link
Member

t-j-h commented Mar 15, 2019

I'm okay with this change - but will leave it open in case others like @levitte and @mattcaswell have a different view.

@richsalz
Copy link
Contributor

i think just putting DRAFT on the front page is enough

@levitte
Copy link
Member

levitte commented Mar 15, 2019

i think just putting DRAFT on the front page is enough

Not sure I understand, since it's one loooooong page. Are you saying that it should stay in position relative the top of this page instead of being fixed in the viewport as it is now?

@t-j-h
Copy link
Member

t-j-h commented Mar 15, 2019

Leaving it as is (present as a watermark) but lighter is the right solution IMHO. i.e. accept this PR as-is.

@mspncp
Copy link
Contributor Author

mspncp commented Mar 15, 2019

Thanks all for your consent. Note however, that neither am I going to merge, nor does my (implicit) approval count, since I don't have commit access.

levitte pushed a commit that referenced this pull request Mar 15, 2019
The strong DRAFT watermark is very distracting while reading and makes
the eyes loose the current reading position while scrolling.

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #127)
@levitte
Copy link
Member

levitte commented Mar 15, 2019

Merged

@mspncp
Copy link
Contributor Author

mspncp commented Mar 15, 2019

Thanks. Now it's perfect :-)

@mspncp
Copy link
Contributor Author

mspncp commented Mar 15, 2019

(Note: Just in case anybody fears that now the watermark text is not readable anymore: inspired by Rich's suggestion one could extend the title line to "OpenSSL 3.0.0 Design (DRAFT)")

@richsalz
Copy link
Contributor

I get the use of watermarks, and I know it's common. They're just a bugaboo of mine. I was merely expressing an opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants