Better dependencies for md->html rendering #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
changed the title
|
This depends on #320. Without that one, building from this PR will fail because of the missing top level |
This was referenced May 6, 2022
levitte
changed the title
|
With #320 approved and merged, this is now rebased and ready for review |
It's too easy to miss adding proper depdencies, so let's make that automatic, at least for md files we have in this repository. All md->html rendering is made to depend on the presence of dirdata.yaml, which will be a good reminder to add it where it's missing.
|
Note that www.openssl.org/roadmap.html currently lacks the expected breadcrumbs, in spite of #320. That's because the dependencies for |
mattcaswell
approved these changes
May 10, 2022
|
Merged 0de56ea Better dependencies for md->html rendering |
openssl-machine
pushed a commit
that referenced
this pull request
May 10, 2022
It's too easy to miss adding proper depdencies, so let's make that automatic, at least for md files we have in this repository. All md->html rendering is made to depend on the presence of dirdata.yaml, which will be a good reminder to add it where it's missing. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #326)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's too easy to miss adding proper dependencies, so let's make that
automatic, at least for md files we have in this repository.
All md->html rendering is made to depend on the presence of dirdata.yaml,
which will be a good reminder to add it where it's missing.