Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert removal of SSI #429

Closed
wants to merge 14 commits into from
Closed

Revert removal of SSI #429

wants to merge 14 commits into from

Conversation

hlandau
Copy link
Member

@hlandau hlandau commented Oct 16, 2023

Urgent due to website breakage

Manpages are now missing.

  • Revert "Remove the SSI artifacts, they are not needed any more"
  • Revert "Fix support/dirdata.yaml to produce more correct breadcrumbs"
  • Revert "Convert SSI includes to tt includes in manpages"
  • Revert "Small fix in bin/mk-mancross: skip missing docs directories"
  • Revert "Ignore temporary OpenSSL build and install directories"
  • Revert "Avoid rendering README.md"
  • Revert "Convert SSI includes to tt includes in source/"
  • Revert "Convert SSI includes to tt includes in policies/"
  • Revert "Convert SSI includes to tt includes in news/"
  • Revert "Convert SSI includes to tt includes in top directory"
  • Revert "Convert SSI includes to tt includes in docs/"
  • Revert "Convert SSI includes to tt includes in community/"
  • Revert "Add a markdown copy of inc/legalities.md"
  • Revert "Add a Makefile rule to allow tpage templates for anything"

@hlandau
Revert "Remove the SSI artifacts, they are not needed any more"
ecaa665 
This reverts commit 9f13778.
@hlandau
Revert "Fix support/dirdata.yaml to produce more correct breadcrumbs"
d4ad4ea 
This reverts commit d52e966.
@hlandau
Revert "Convert SSI includes to tt includes in manpages"
5eac01c 
This reverts commit 58c8d7c.
@hlandau
Revert "Small fix in bin/mk-mancross: skip missing docs directories"
00cadc0 
This reverts commit 028c0c7.
@hlandau
Revert "Ignore temporary OpenSSL build and install directories"
af8601d 
This reverts commit 655ce39.
@hlandau
Revert "Avoid rendering README.md"
e813372 
This reverts commit 0ef7190.
@hlandau
Revert "Convert SSI includes to tt includes in source/"
76d13c1 
This reverts commit 25959f5.
@hlandau
Revert "Convert SSI includes to tt includes in policies/"
8335630 
This reverts commit 3e0fca0.
@hlandau
Revert "Convert SSI includes to tt includes in news/"
4a2369b 
This reverts commit 7b1bc58.
@hlandau
Revert "Convert SSI includes to tt includes in top directory"
d9a9d57 
This reverts commit ec5b365.
@hlandau
Revert "Convert SSI includes to tt includes in docs/"
a0fbac8 
This reverts commit 55928bc.
@hlandau
Revert "Convert SSI includes to tt includes in community/"
76eae38 
This reverts commit d0d42d8.
@hlandau
Revert "Add a markdown copy of inc/legalities.md"
e6ca456 
This reverts commit d20569c.
@hlandau
Revert "Add a Makefile rule to allow tpage templates for anything"
dee444d 
This reverts commit 3e7c578.
@hlandau hlandau added the URGENT label Oct 16, 2023
@hlandau hlandau requested a review from a team October 16, 2023 15:46
@hlandau hlandau self-assigned this Oct 16, 2023
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Remove the SSI artifacts, they are not needed any more"
42aef67 
This reverts commit 9f13778.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Fix support/dirdata.yaml to produce more correct breadcrumbs"
d47e307 
This reverts commit d52e966.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Convert SSI includes to tt includes in manpages"
5623c80 
This reverts commit 58c8d7c.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Small fix in bin/mk-mancross: skip missing docs directories"
b757d06 
This reverts commit 028c0c7.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Ignore temporary OpenSSL build and install directories"
2c3b9f8 
This reverts commit 655ce39.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Avoid rendering README.md"
b7519f6 
This reverts commit 0ef7190.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Convert SSI includes to tt includes in source/"
6679d91 
This reverts commit 25959f5.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Convert SSI includes to tt includes in policies/"
c53e300 
This reverts commit 3e0fca0.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Convert SSI includes to tt includes in news/"
a939a0a 
This reverts commit 7b1bc58.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Convert SSI includes to tt includes in top directory"
0090331 
This reverts commit ec5b365.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Convert SSI includes to tt includes in docs/"
7e8a6ff 
This reverts commit 55928bc.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Convert SSI includes to tt includes in community/"
646ed9c 
This reverts commit d0d42d8.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Add a markdown copy of inc/legalities.md"
7b79fcc 
This reverts commit d20569c.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
openssl-machine pushed a commit that referenced this pull request Oct 16, 2023
@hlandau @mattcaswell
Revert "Add a Makefile rule to allow tpage templates for anything"
8d59953 
This reverts commit 3e7c578.

Reviewed-by: Anton Arapov <anton@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #429)
@levitte
Copy link
Member

levitte commented Oct 16, 2023

I don't this is what caused the problem. See https://beta.openssl.org/ for a successful result of the SSI removal PR.

However, we call the documentation stuff much more separately for our canonical web ('cause that's the way to handle it when changes happen in several branches and one has to keep track of the different checkouts without stumbling on your own virtual toes), and I definitely believe that's where the issue actually lies.

@levitte
Copy link
Member

levitte commented Oct 16, 2023

That being said, the current Makefile still lacks the targets needed to easily produce documentation on a per-releases / per-branch basis. That should hopefully not be too hard to add, though.

@levitte levitte closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arapov arapov arapov approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

@hlandau hlandau

Labels
URGENT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hlandau @levitte @arapov @mattcaswell