Specify defaults for pip_install_upper_constraints

If this role is run without having pip_install_upper_constraints set then you'll get a failure stating that pip_install_upper_constraints is undefined. This patch simply adds the default filter when referencing pip_install_upper_constraints, which seems to be the pattern used in openstack-ansible's utility-install.yml playbook. Change-Id: If1b68fb21e0eb8f2f8c33a6bec952c2972e3e5e3
openstack-archive · Apr 3, 2018 · 5a99262 · 5a99262
1 parent f2e2d92
commit 5a99262
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tasks/install_offline.yml b/tasks/install_offline.yml
@@ -68,7 +68,7 @@
     command python /tmp/get-pip.py
                    -d '{{ pip_tmp_packages | quote }}'
                    {{ (pip_install_upper_constraints is defined) |
-                      ternary('--constraint ' ~ pip_install_upper_constraints, '') }}
+                      ternary('--constraint ' ~ pip_install_upper_constraints | default(''), '') }}
                    {{ pip_get_pip_options }}
                    {{ pip_packages | map('quote') | join (' ') }}
   changed_when: pip_local_cache.stdout.find('Successfully downloaded') != -1

diff --git a/tasks/install_source.yml b/tasks/install_source.yml
@@ -17,7 +17,7 @@
     - name: Install PIP
       command: >
         python /opt/get-pip.py {{ (pip_install_upper_constraints is defined) |
-                                  ternary('--constraint ' ~ pip_install_upper_constraints, '') }}
+                                  ternary('--constraint ' ~ pip_install_upper_constraints | default(''), '') }}
                                {{ pip_source_install_options }}
                                {{ pip_get_pip_options }}
                                {{ pip_packages | map('quote') | join (' ') }}
@@ -32,7 +32,7 @@
       command: >
         python /opt/get-pip.py --isolated
                                {{ (pip_install_upper_constraints is defined) |
-                                  ternary('--constraint ' ~ pip_install_upper_constraints, '') }}
+                                  ternary('--constraint ' ~ pip_install_upper_constraints | default(''), '') }}
                                {{ pip_source_install_options }}
                                {{ pip_get_pip_options }}
                                {{ pip_packages | map('quote') | join (' ') }}