Publish vault_url when publish_url is called #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous attempt to solve the external/internal binding problem made it possible to call the interface's publish_url but not actually set vault_url if subnets happen to not match. This can be the case in a number of instances including CMR, AWS and multiple spaces. This change simplifies the interface and guarantees when publish_url is called that vault_url is set. The address selection logic should reside in the vault charm. Closes-Bug: #1895185
thedac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous attempt to solve the external/internal binding problem made it
possible to call the interface's publish_url but not actually set
vault_url if subnets happen to not match. This can be the case in a
number of instances including CMR, AWS and multiple spaces.
This change simplifies the interface and guarantees when publish_url is
called that vault_url is set.
The address selection logic should reside in the vault charm.
Closes-Bug: #1895185