Specialize udevadm rescan to target block device #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the udevadm trigger call to only match the device being used; this avoids rebuilding /dev/disk/by-*/* symlinks for all block devices and the assocaited race conditions that might exist when a system is under load.
|
To confirm; I also tested this using /dev/disk/by-dname configuration options in the ceph-osd charm; these are used right down into the vaultlocker layer and I wanted to confirm that this change does not revert the previous commit which forced a full rescan of block devices. Worked OK |
ChrisMacNaughton
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the udevadm trigger call to only match the device being
used; this avoids rebuilding /dev/disk/by-/ symlinks for all
block devices and the assocaited race conditions that might
exist when a system is under load.