Fix ceph-iscsi tests (yoga) #1019
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
did mostly the same, but this PR makes it more similar to what we have pending for the stable branches. This PR is being tested in this gerrit patchset: https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/871154
openstack-mirroring
pushed a commit
to openstack/charm-ceph-iscsi
that referenced
this pull request
Apr 24, 2023
Tox 4.0.0 was recently released and it has several breaking changes. We pin to < 4.0.0 here. We are planning to move forward only on the master charm branches. Tox is also pinned to < 4.0.0 for stable branches in upstream openstack-zuul-jobs as well as in zosci-config. However, the requires= section in the charm's tox.ini file ends up installing tox>4, wiping out the zuul-pinned tox<4 that was already installed installed. This patch fixes that. Related-Bug: #2002788 Change-Id: Ib3af2849d6d9ee660f1bb641eb16ff3f1c384a61 func-test-pr: openstack-charmers/zaza-openstack-tests#1019
coreycb
suggested changes
Sep 15, 2023
| self.check_client_device(test_ctxt, init_client=True) | ||
| self.logout_iscsi_targets(test_ctxt) | ||
| self.login_iscsi_target(test_ctxt) | ||
| self.refresh_partitions(test_ctxt) | ||
| self.check_client_device(test_ctxt, init_client=False) |
There was a problem hiding this comment.
Does this need a final call to "self.refresh_partitions(test_ctxt)" here? I noticed that stable/zed has that call here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR did mostly the same, but this PR makes it more similar to what we have pending for the stable branches.
This PR is being tested in this gerrit patchset:
https://review.opendev.org/c/openstack/charm-ceph-iscsi/+/871327