Ensure keystone endpoint is available #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keystone-ldap tests are failing often due to accessing the keystone endpoint before it is available. Adding tenacity retries here to deal with this.
freyes
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
LGTM. Waiting for the CI results to return. https://review.opendev.org/c/openstack/charm-keystone-ldap/+/873802
openstack-mirroring
pushed a commit
to openstack/charm-keystone-ldap
that referenced
this pull request
Mar 14, 2023
* sync charm-helpers to classic charms * change openstack-origin/source default to antelope * align testing with antelope * add new antelope bundles * add antelope bundles to tests.yaml * add antelope tests to osci.yaml and .zuul.yaml * update build-on and run-on bases func-test-pr: openstack-charmers/zaza-openstack-tests#1023 Change-Id: Ibbf2a113ee893e971255b84698565261baf1ed3f
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Mar 14, 2023
* Update charm-keystone-ldap from branch 'master'
to 8c7c82e425040b8e347d12634f0df4d530b3ce76
- Add Antelope support
* sync charm-helpers to classic charms
* change openstack-origin/source default to antelope
* align testing with antelope
* add new antelope bundles
* add antelope bundles to tests.yaml
* add antelope tests to osci.yaml and .zuul.yaml
* update build-on and run-on bases
func-test-pr: openstack-charmers/zaza-openstack-tests#1023
Change-Id: Ibbf2a113ee893e971255b84698565261baf1ed3f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keystone-ldap tests are failing often due to accessing the keystone endpoint before it is available. Adding tenacity retries here to deal with this.