Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Quagga to FRR #1060

Merged
merged 2 commits into from May 25, 2023
Merged

Switch from Quagga to FRR #1060

merged 2 commits into from May 25, 2023

Conversation

dshcherb
Copy link
Contributor

A charm that uses FRR instead of Quagga is now published under: https://charmhub.io/osci-frr

For our purposes FRR is a drop-in replacement of Quagga but the point of a change is to remove Quagga references for clarity.

A charm that uses FRR instead of Quagga is now published under:
https://charmhub.io/osci-frr

For our purposes FRR is a drop-in replacement of Quagga but the point
of a change is to remove Quagga references for clarity.
@dshcherb dshcherb requested a review from fnordahl May 23, 2023 18:54
ad16b5a

ad16b5a introduced an option to
customize network and subnet names, however, not all modules were
updated to pass it into the setup_sdn method. Specificatlly, the
dragent now breaks with a KeyError during the configure step.

(Pdb) network_config["project_net_name"]
*** KeyError: 'project_net_name'

https://github.com/openstack-charmers/zaza-openstack-tests/blob/fdaf43f52c31656e445561477a7b7c468a73b89a/zaza/openstack/charm_tests/dragent/configure.py#L35-L46
Copy link
Contributor

@fnordahl fnordahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fnordahl fnordahl merged commit 4b56ec1 into master May 25, 2023
6 checks passed
openstack-mirroring pushed a commit to openstack/charm-neutron-dynamic-routing that referenced this pull request May 25, 2023
* Switch to test bundles;
* Update charmcraft.yaml;
* Update requirements files;
* Switch to ch:osci-frr from ch:quagga;
* Update tox config files.

Func-Test-PR: openstack-charmers/zaza-openstack-tests#1060
Change-Id: Ie611966bb19631a586285f45f27dc52b96ff2937
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request May 25, 2023
* Update charm-neutron-dynamic-routing from branch 'master'
  to 5963ea4fc32ef269d93f2fc8e05b363815397c43
  - Update the charm for new releases
    
    * Switch to test bundles;
    * Update charmcraft.yaml;
    * Update requirements files;
    * Switch to ch:osci-frr from ch:quagga;
    * Update tox config files.
    
    Func-Test-PR: openstack-charmers/zaza-openstack-tests#1060
    Change-Id: Ie611966bb19631a586285f45f27dc52b96ff2937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants