[yoga] Add test to check ceph keys #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For https://review.opendev.org/897549 (cherry picked from commit 912f33e) (cherry picked from commit e242121) (cherry picked from commit d1a5ab4) (cherry picked from commit e23e14b)
dosaboy
reviewed
Mar 7, 2024
| check_keyring(self.application_name) | ||
| # new key | ||
| check_keyring('nova-compute-ceph-auth-c91ce26f') | ||
|
|
||
| def test_930_check_virsh_default_network(self): |
There was a problem hiding this comment.
check_keyring is referring to variable "unit" that is from global space. It should be passed into check_keyring() as an argument.
There was a problem hiding this comment.
omg yes, that slipped by, we will need to fix it in master and bobcat as well
There was a problem hiding this comment.
actually, I just tested the logic and that coding problem does not affect the result at all
There was a problem hiding this comment.
yep no worries, can just fix on master if we get time
openstack-mirroring
pushed a commit
to openstack/charm-nova-compute
that referenced
this pull request
Mar 11, 2024
This change reworks previous changes [1] and [2] that had been respectively reverted and abandoned. When using the config libvirt-image-backend=rbd, VMs created from image have their disk data stored in ceph instead of the compute node itself. When performing live-migrations, both nodes need to access the same ceph credentials to access the VM's disk in ceph, but this is currently not possible if the nodes involved pertain to different nova-compute charm apps. This patch changes app name sent to ceph to 'nova-compute-ceph-auth-c91ce26f', a unique name common to all nova-compute apps, allowing all nova-compute apps to use the same ceph auth. This change also ensures newly deployed nodes install the old credentials first on ceph-joined hook, and then supercedes it with the new credentials on ceph-changed hook, therefore also retaining the old credentials. [1] https://review.opendev.org/889642 [2] https://review.opendev.org/896155 Closes-bug: #2028559 Related-bug: #2037003 Func-Test-Pr: openstack-charmers/zaza-openstack-tests#1190 Change-Id: I1ae12d787a1f8e7761ca06b5a80049c1c62e9e90 (cherry picked from commit 650f3a5) (cherry picked from commit 28233f9) (cherry picked from commit ecaf801) (cherry picked from commit 8c3549d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://review.opendev.org/897549
(cherry picked from commit 912f33e) (cherry picked from commit e242121) (cherry picked from commit d1a5ab4) (cherry picked from commit e23e14b)