Implement tests for ceph-mon's rotate-key action #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements tests for the ceph-mon charm's action 'rotate-key'. For now, the charm only supports key rotation for managers, but more entities will be added. This PR will be used to test those new entities as well.
sabaini
reviewed
Apr 9, 2024
openstack-mirroring
pushed a commit
to openstack/charm-ceph-mon
that referenced
this pull request
Apr 9, 2024
This patchset implements key rotation for managers only. The user can specified either the full entity name (i.e: 'mgr.XXXX') or simply 'mgr', which stands for the local manager. After the entity's directory is located, a new pending key is generated, the keyring file is mutated to include the new key and then replaced in situ. Lastly, the manager service is restarted. Note that Ceph only has one active manager at a certain point, so it only makes sense to call this action on _every_ mon unit. Change-Id: Ie24b3f30922fa5be6641e37635440891614539d5 func-test-pr: openstack-charmers/zaza-openstack-tests#1195
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Apr 9, 2024
* Update charm-ceph-mon from branch 'master'
to 05725042300c02ef4f7490e3e1a34b84be8ddcbe
- Implement the 'rotate-key' action for managers
This patchset implements key rotation for managers only. The user
can specified either the full entity name (i.e: 'mgr.XXXX') or
simply 'mgr', which stands for the local manager.
After the entity's directory is located, a new pending key is
generated, the keyring file is mutated to include the new key and
then replaced in situ. Lastly, the manager service is restarted.
Note that Ceph only has one active manager at a certain point,
so it only makes sense to call this action on _every_ mon unit.
Change-Id: Ie24b3f30922fa5be6641e37635440891614539d5
func-test-pr: openstack-charmers/zaza-openstack-tests#1195
sabaini
reviewed
Apr 12, 2024
yes. the patchset for OSDs isn't ready yet, and I want this PR to be run for its functional tests. |
openstack-mirroring
pushed a commit
to openstack/charm-ceph-mon
that referenced
this pull request
Apr 12, 2024
This patchset implements the needed functionality on the ceph-mon charm to rotate the key of a specified RadosGW daemon. func-test-pr: openstack-charmers/zaza-openstack-tests#1195 Change-Id: I6dbbf6ca1292a34f5d3b4ff8f2966c8b77f53f48
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Apr 12, 2024
* Update charm-ceph-mon from branch 'master'
to 446d17f625b5c750b273afd84b9ebd628a48fc9c
- Implement key rotation for RadosGW daemons
This patchset implements the needed functionality on the ceph-mon
charm to rotate the key of a specified RadosGW daemon.
func-test-pr: openstack-charmers/zaza-openstack-tests#1195
Change-Id: I6dbbf6ca1292a34f5d3b4ff8f2966c8b77f53f48
openstack-mirroring
pushed a commit
to openstack/charm-ceph-radosgw
that referenced
this pull request
Apr 18, 2024
This patchset implements key rotation in the ceph-radosgw charm, by replacing the keyring file if it exists and the ceph-mon relation reports a new key. Change-Id: I447b5f827e39118e7dbd430b1c63b3ec4ea3e176 func-test-pr: openstack-charmers/zaza-openstack-tests#1195
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Apr 18, 2024
* Update charm-ceph-radosgw from branch 'master'
to 940be7fdfc6729ffeb7dd37d50943a2aeecdcda6
- Implement key rotation on the ceph-radosgw charm
This patchset implements key rotation in the ceph-radosgw charm,
by replacing the keyring file if it exists and the ceph-mon
relation reports a new key.
Change-Id: I447b5f827e39118e7dbd430b1c63b3ec4ea3e176
func-test-pr: openstack-charmers/zaza-openstack-tests#1195
lmlg
changed the title
|
The PR is ready for merge now. The mgr and RGW pieces have been run with this PR already. |
|
This PR has been successfully tested on these MR's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements tests for the ceph-mon charm's action 'rotate-key'. For now, the charm only supports key rotation for managers, but more entities will be added. This PR will be used to test those new entities as well.