Add a ceilometer test case and fix existing ones for trusty/mitaka #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnordahl
reviewed
Mar 5, 2020
| assert(ceil.samples.list() == []) | ||
| assert(ceil.meters.list() == []) | ||
|
|
||
| # NOTE(beisner): need to add more functional tests |
There was a problem hiding this comment.
Probably safe to remove this comment now
|
openstack-gerrit
pushed a commit
to openstack/charm-ceilometer
that referenced
this pull request
Mar 6, 2020
Zaza tests can be found here: openstack-charmers/zaza-openstack-tests#59 openstack-charmers/zaza-openstack-tests#185 Support Python 3.8 by pulling a version of charm-helpers containing juju/charm-helpers#423 Func-Test-PR: openstack-charmers/zaza-openstack-tests#185 Closes-Bug: #1828424 Change-Id: I844836b0c2f7556da0b73a7917b8ec18052ba841
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Mar 6, 2020
* Update charm-ceilometer from branch 'master'
- Porting tests from Amulet to Zaza and support for Python 3.8
Zaza tests can be found here:
openstack-charmers/zaza-openstack-tests#59
openstack-charmers/zaza-openstack-tests#185
Support Python 3.8 by pulling a version of charm-helpers containing juju/charm-helpers#423
Func-Test-PR: openstack-charmers/zaza-openstack-tests#185
Closes-Bug: #1828424
Change-Id: I844836b0c2f7556da0b73a7917b8ec18052ba841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/charm-ceilometer/+bug/1828424