Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NovaCloudController test cases #233

Merged
merged 14 commits into from Apr 21, 2020
Merged

NovaCloudController test cases #233

merged 14 commits into from Apr 21, 2020

Conversation

lourot
Copy link
Contributor

@lourot lourot commented Apr 17, 2020

Not yet covering the same amount as nova-cloud-controller's Amulet tests.
https://launchpad.net/bugs/1828424
@lourot
Copy link
Contributor Author

lourot commented Apr 17, 2020

CI runs: https://review.opendev.org/720658

@lourot lourot changed the title First NovaCloudController test cases NovaCloudController test cases Apr 20, 2020
@codecov-io
Copy link

codecov-io commented Apr 20, 2020

Codecov Report

Merging #233 into master will decrease coverage by 0.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   20.85%   20.53%   -0.32%     
==========================================
  Files         129      129              
  Lines        7079     7189     +110     
==========================================
  Hits         1476     1476              
- Misses       5603     5713     +110     
Impacted Files Coverage Δ
zaza/openstack/charm_tests/nova/tests.py 0.00% <0.00%> (ø)
zaza/openstack/charm_tests/test_utils.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ae109a...9477fd4. Read the comment docs.

@dshcherb
Copy link
Contributor

Here's a summary after reviewing compared to https://github.com/openstack/charm-nova-cloud-controller/blob/65ed6620c7594cac914d21c2203742f63dc43d17/tests/basic_deployment.py#L74-L1045:

test_100_services - reworked (test_106_compute_catalog_endpoints)
test_102_service_catalog - reworked (test_106_compute_catalog_endpoints)

test_106_ec2_api_endpoint - N/A
test_108_s3_api_endpoint - N/A
test_110_memcache - N/A (do we assume that there are higher-level tests?)

test_200_nova_cc_shared_db_relation - N/A (assuming that we have higher-level tests)
test_202_mysql_shared_db_relation- N/A (assuming that we have higher-level tests)
test_204_nova_cc_identity_service_relation - N/A (assuming that we have higher-level tests)
test_206_keystone_identity_service_relation - N/A (assuming that we have higher-level tests)
test_208_nova_cc_amqp_relation - N/A (assuming that we have higher-level tests)
test_210_rabbitmq_amqp_relation - N/A (assuming that we have higher-level tests)
test_212_nova_cc_cloud_compute_relation - N/A (assuming that we have higher-level tests)
test_214_nova_cloud_compute_relation - N/A (tests for nova-compute validate this)
test_216_nova_cc_image_service_relation - N/A (assuming that we have higher-level tests that validate this better than this test case)
test_218_glance_image_service_relation - N/A (assuming that we have higher-level tests that validate glance)

test_302_api_rate_limiting_is_enabled - rewritten
test_310_pci_alias_config - rewritten

test_400_image_instance_create - already covered by tests enabled in charm-nova-compute (LTSGuestCreateTest et al.)
test_901_pause_resume - already there
test_900_restart_on_config_change - already there

@dshcherb dshcherb merged commit 4acd501 into openstack-charmers:master Apr 21, 2020
@lourot lourot deleted the nova-cloud-controller branch April 21, 2020 06:53
openstack-gerrit pushed a commit to openstack/charm-nova-cloud-controller that referenced this pull request Apr 21, 2020
Change-Id: Ief33e4bebff904778df18fafb77c318ec212677b
Closes-Bug: #1828424
Func-Test-PR: openstack-charmers/zaza-openstack-tests#233
openstack-gerrit pushed a commit to openstack/openstack that referenced this pull request Apr 21, 2020
* Update charm-nova-cloud-controller from branch 'master'
  - Migrate functional tests from Amulet to Zaza
    
    Change-Id: Ief33e4bebff904778df18fafb77c318ec212677b
    Closes-Bug: #1828424
    Func-Test-PR: openstack-charmers/zaza-openstack-tests#233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants