-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zaza tests for TrilioVault #252
Add zaza tests for TrilioVault #252
Conversation
3757804
to
4a73575
Compare
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 20.85% 20.02% -0.83%
==========================================
Files 129 134 +5
Lines 7079 7380 +301
==========================================
+ Hits 1476 1478 +2
- Misses 5603 5902 +299
Continue to review full report at Codecov.
|
67dacde
to
d79faec
Compare
Add setup and tests for trilio-{data-mover,dm-api,wlm} charms. Add attach_volume utility to attach cinder volumes to nova servers.
d79faec
to
eb0cba9
Compare
@@ -487,6 +487,24 @@ def get_project_id(ks_client, project_name, api_version=2, domain_name=None): | |||
return None | |||
|
|||
|
|||
def get_domain_id(ks_client, domain_name, api_version=2): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javacruft api_version looks unused.
:type ks_client: keystoneclient.v3.Client object | ||
:param domain_name: Name of the domain | ||
:type domain_name: string | ||
:param api_version: API version number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
fatal=True, | ||
) | ||
|
||
# TODO validate restore but currently failing with 4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's discuss this later.
Looks good to me overall. I made 1 comment about an extra argument in |
I'm working on getting the restore test working still - there are some bugs/configuration issues in the data-mover which are currently blocking it from succeeding |
I see, I think we can do it in a follow-up PR then. Just waiting for the full func test to pass on https://review.opendev.org/#/c/721683/ acknowledging that it needs a full cloud to be stood up. |
Add setup and tests for trilio-{data-mover,dm-api,wlm} charms.
The actual functional test for TrilioVault still needs to be developed
but the configure steps validate quite a bit of the deployment.