Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zaza tests for TrilioVault #252

Merged
merged 1 commit into from
May 5, 2020

Conversation

javacruft
Copy link
Contributor

Add setup and tests for trilio-{data-mover,dm-api,wlm} charms.

The actual functional test for TrilioVault still needs to be developed
but the configure steps validate quite a bit of the deployment.

zaza/openstack/charm_tests/trilio/setup.py Outdated Show resolved Hide resolved
zaza/openstack/charm_tests/trilio/setup.py Outdated Show resolved Hide resolved
zaza/openstack/charm_tests/trilio/tests.py Outdated Show resolved Hide resolved
@javacruft javacruft force-pushed the triliovault-testing branch 5 times, most recently from 3757804 to 4a73575 Compare May 1, 2020 16:44
@codecov-io
Copy link

codecov-io commented May 1, 2020

Codecov Report

Merging #252 into master will decrease coverage by 0.82%.
The diff coverage is 1.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   20.85%   20.02%   -0.83%     
==========================================
  Files         129      134       +5     
  Lines        7079     7380     +301     
==========================================
+ Hits         1476     1478       +2     
- Misses       5603     5902     +299     
Impacted Files Coverage Δ
zaza/openstack/charm_tests/trilio/__init__.py 0.00% <0.00%> (ø)
zaza/openstack/charm_tests/trilio/setup.py 0.00% <0.00%> (ø)
zaza/openstack/charm_tests/trilio/tests.py 0.00% <0.00%> (ø)
zaza/openstack/utilities/openstack.py 53.46% <25.00%> (-0.31%) ⬇️
zaza/openstack/configure/masakari.py 0.00% <0.00%> (ø)
zaza/openstack/configure/hacluster.py 0.00% <0.00%> (ø)
zaza/openstack/charm_tests/aodh/tests.py 0.00% <0.00%> (ø)
zaza/openstack/charm_tests/ceph/tests.py 0.00% <0.00%> (ø)
zaza/openstack/charm_tests/nova/tests.py 0.00% <0.00%> (ø)
zaza/openstack/charm_tests/test_utils.py 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6f1a1...eb0cba9. Read the comment docs.

@javacruft javacruft force-pushed the triliovault-testing branch 17 times, most recently from 67dacde to d79faec Compare May 4, 2020 11:10
Add setup and tests for trilio-{data-mover,dm-api,wlm} charms.

Add attach_volume utility to attach cinder volumes to nova servers.
@@ -487,6 +487,24 @@ def get_project_id(ks_client, project_name, api_version=2, domain_name=None):
return None


def get_domain_id(ks_client, domain_name, api_version=2):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javacruft api_version looks unused.

:type ks_client: keystoneclient.v3.Client object
:param domain_name: Name of the domain
:type domain_name: string
:param api_version: API version number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

fatal=True,
)

# TODO validate restore but currently failing with 4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's discuss this later.

@dshcherb
Copy link
Contributor

dshcherb commented May 4, 2020

Looks good to me overall.

I made 1 comment about an extra argument in get_domain_id and we also need to figure out what to do about the restore functionality validation with 4.0.

@javacruft
Copy link
Contributor Author

I'm working on getting the restore test working still - there are some bugs/configuration issues in the data-mover which are currently blocking it from succeeding

@dshcherb
Copy link
Contributor

dshcherb commented May 5, 2020

I see, I think we can do it in a follow-up PR then.

Just waiting for the full func test to pass on https://review.opendev.org/#/c/721683/ acknowledging that it needs a full cloud to be stood up.

@dshcherb dshcherb merged commit 4ab3681 into openstack-charmers:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants