Add setup for glance-simplestreams-sync #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 19.23% 19.22% -0.02%
==========================================
Files 149 150 +1
Lines 8051 8056 +5
==========================================
Hits 1549 1549
- Misses 6502 6507 +5
Continue to review full report at Codecov.
|
Use action to complete initial image sync for the gss charm. This avoids races where the images end up in the wrong locations and allows the tests to actually know when images should be discoverable. Update tests to wait for at least four images (20.04 is synced by default).
thedac
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Looks good. Will land simultaneously with https://review.opendev.org/#/c/733097
|
Actually, this can land now as nothing is calling it. |
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jun 18, 2020
* Update charm-glance-simplestreams-sync from branch 'master'
- Switch to using snap for simplestreams tools
Switch over to using the new simplestreams snap instead of using
the largely unmaintained packaging in distro (and various PPA's).
This drops direct integration with the simplestreams codebase
in preference to just calling the sstream-mirror-glance command
with the correct parameters.
This commit includes refactoring of 'custom_properties' handling
which was actually broken - there was no loading of the yaml
formatted list, which was probably overkill, so the option now
takes a space separated list of key=value pairs, for example:
custom_properties="hw_firmware_type=uefi hw_vif_multiqueue_enabled=true"
Fix version comparison in script wrapper.
Drop Trusty support - snaps on Trusty are awkward requiring new
kernel versions and trusty support was only retained for upgrade
purposes anyway.
Drop unsupported Xenial OpenStack versions.
Fixup CA cert handling to use any charm installed CA cert (including
that provided via the certificates relation) and install cert
to snap compatible location for simplestreams to use.
Add basic action to perform image sync on demand an refactor
the glance simplestreams sync wrapper to work within a hook
context to support the action.
Disable automatic scheduling of image syncs by default as this
tends to be racey during deployment resulting in images being
synced to glance unit local storage.
Add bionic-ussuri bundle and make it the default smoke test.
Deprecate source and key options - no longer required for
deployment with snap.
Change-Id: I730df6b7f5955ddfeea5b8de15490ac083823f5a
Func-Test-PR: openstack-charmers/zaza-openstack-tests#321
openstack-mirroring
pushed a commit
to openstack/charm-glance-simplestreams-sync
that referenced
this pull request
Jun 18, 2020
Switch over to using the new simplestreams snap instead of using the largely unmaintained packaging in distro (and various PPA's). This drops direct integration with the simplestreams codebase in preference to just calling the sstream-mirror-glance command with the correct parameters. This commit includes refactoring of 'custom_properties' handling which was actually broken - there was no loading of the yaml formatted list, which was probably overkill, so the option now takes a space separated list of key=value pairs, for example: custom_properties="hw_firmware_type=uefi hw_vif_multiqueue_enabled=true" Fix version comparison in script wrapper. Drop Trusty support - snaps on Trusty are awkward requiring new kernel versions and trusty support was only retained for upgrade purposes anyway. Drop unsupported Xenial OpenStack versions. Fixup CA cert handling to use any charm installed CA cert (including that provided via the certificates relation) and install cert to snap compatible location for simplestreams to use. Add basic action to perform image sync on demand an refactor the glance simplestreams sync wrapper to work within a hook context to support the action. Disable automatic scheduling of image syncs by default as this tends to be racey during deployment resulting in images being synced to glance unit local storage. Add bionic-ussuri bundle and make it the default smoke test. Deprecate source and key options - no longer required for deployment with snap. Change-Id: I730df6b7f5955ddfeea5b8de15490ac083823f5a Func-Test-PR: openstack-charmers/zaza-openstack-tests#321
openstack-mirroring
pushed a commit
to openstack/charm-glance-simplestreams-sync
that referenced
this pull request
Jun 18, 2020
Drop support for sending sync status messages to a RMQ exchange. This was used by conjure-up which is no longer maintained so drop the supporting code, metadata and options and remove RabbitMQ from all test bundles. Change-Id: I504508a64e50a9d331f6c5d69b292d9ccc20da3d Func-Test-PR: openstack-charmers/zaza-openstack-tests#321
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jun 18, 2020
* Update charm-glance-simplestreams-sync from branch 'master'
- Drop RabbitMQ support
Drop support for sending sync status messages to a RMQ exchange.
This was used by conjure-up which is no longer maintained so
drop the supporting code, metadata and options and remove
RabbitMQ from all test bundles.
Change-Id: I504508a64e50a9d331f6c5d69b292d9ccc20da3d
Func-Test-PR: openstack-charmers/zaza-openstack-tests#321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use action to complete initial image sync for the gss charm.
This avoids races where the images end up in the wrong locations
and allows the tests to actually know when images should be
discoverable.
Update tests to wait for at least four images (20.04 is synced
by default).