Dashboard ssl #389
Merged
Dashboard ssl #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 19, 2020 12:36
Update horizin tests to support https if available.
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
- Coverage 18.77% 18.73% -0.05%
==========================================
Files 152 152
Lines 8267 8285 +18
==========================================
Hits 1552 1552
- Misses 6715 6733 +18
Continue to review full report at Codecov.
|
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 21, 2020
* Update charm-openstack-dashboard from branch 'master'
- Ensure that certificates are correctly managed.
When the certificates relation is ready before the
HA relation is clustered, the VIP symlinks will not
be created pointing at the correct certificates. This
change updates the HA handlers to ensure that the
certificate relation is handled after clustering,
if there are any certificate relations.
There was no functional test coverage for HA and TLS
deployments so this change also add a test for
those and CMR too. Having said that, the test
initialises vault once the deployments are
complete so is unlikely to trigger #1886077 the tests
to check there is no regression of exising
functionality.
func-test-pr: openstack-charmers/zaza-openstack-tests#389
Change-Id: I7c9c81318dbbcea618ac3781b8f19e8159e56bcb
Closes-Bug: #1886077
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Aug 21, 2020
When the certificates relation is ready before the HA relation is clustered, the VIP symlinks will not be created pointing at the correct certificates. This change updates the HA handlers to ensure that the certificate relation is handled after clustering, if there are any certificate relations. There was no functional test coverage for HA and TLS deployments so this change also add a test for those and CMR too. Having said that, the test initialises vault once the deployments are complete so is unlikely to trigger #1886077 the tests to check there is no regression of exising functionality. func-test-pr: openstack-charmers/zaza-openstack-tests#389 Change-Id: I7c9c81318dbbcea618ac3781b8f19e8159e56bcb Closes-Bug: #1886077
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Sep 22, 2020
When the certificates relation is ready before the HA relation is clustered, the VIP symlinks will not be created pointing at the correct certificates. This change updates the HA handlers to ensure that the certificate relation is handled after clustering, if there are any certificate relations. There was no functional test coverage for HA and TLS deployments so this change also add a test for those and CMR too. Having said that, the test initialises vault once the deployments are complete so is unlikely to trigger #1886077 the tests to check there is no regression of existing functionality. func-test-pr: openstack-charmers/zaza-openstack-tests#389 Change-Id: I7c9c81318dbbcea618ac3781b8f19e8159e56bcb Closes-Bug: #1886077 (cherry picked from commit b9905a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.