New test for Gnocchi #393
Merged
New test for Gnocchi #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedac
suggested changes
Aug 20, 2020
|
|
||
| cert_location = '/usr/local/share/ca-certificates' | ||
| cert_name = 'gnocchi-external.crt' | ||
| cmd = 'ls ' + cert_location + '/' + cert_name |
There was a problem hiding this comment.
Let's use block_until_file_has_contents or block_until_file_ready rather than a simple ls.
https://github.com/openstack-charmers/zaza/blob/master/zaza/model.py#L1246
https://github.com/openstack-charmers/zaza/blob/master/zaza/model.py#L1288
There was a problem hiding this comment.
I updated the PR using block_until_file_has_contents.
|
|
||
| linked_cert_location = '/etc/ssl/certs' | ||
| linked_cert_name = 'gnocchi-external.pem' | ||
| cmd = 'ls ' + linked_cert_location + '/' + linked_cert_name |
Replace ls with block_until_file_has_contents
thedac
approved these changes
Aug 20, 2020
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Aug 20, 2020
To connect to an external S3 endpoint with encryption, a root CA needs to be installed on the gnocchi units. Func-test-PR: openstack-charmers/zaza-openstack-tests#393 Change-Id: I50fd881400d4c1bf4beaa70d75af34c28c98ea41
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 20, 2020
* Update charm-gnocchi from branch 'master'
- Add trusted-external-ca-cert option
To connect to an external S3 endpoint with encryption,
a root CA needs to be installed on the gnocchi units.
Func-test-PR: openstack-charmers/zaza-openstack-tests#393
Change-Id: I50fd881400d4c1bf4beaa70d75af34c28c98ea41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring Gnocchi to use an external endpoint for an S3 backend, it can be necessary to install a root CA on the gnocchi unit to communicate to this endpoint when it is encrypted. The PR https://review.opendev.org/#/c/746562/ adds automation for this option, and these tests confirm its functionality.
A new charm class is added for these tests, to avoid breaking any earlier version of the charm.