Add NRPE check tests for Designate #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a simple test for the Designate application to ensure that the NRPE checks for services have been created. Related-Bug: #1897809
Change-Id: Ib36cf72fe20aa2b46a80f2d71bcd1400fd70fb8e
|
Gerrit review making use of it: https://review.opendev.org/c/openstack/charm-designate/+/755691 |
lourot
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Happy to land this together with https://review.opendev.org/c/openstack/charm-designate/+/755691 , thanks!
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Aug 26, 2021
Adds the nrpe-external-master layer and checks for services managed by this charm. func-test-pr: openstack-charmers/zaza-openstack-tests#436 Change-Id: Ice5eada838626059f8cb2c427f7b9b0884317660 Closes-Bug: #1897809 Related-Bug: #1933643 Co-authored-by: Aurelien Lourot <aurelien.lourot@canonical.com>
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 26, 2021
* Update charm-designate from branch 'master'
to 3ae0be599b4433919e3db6526a26070fea536db5
- Add NRPE checks for services
Adds the nrpe-external-master layer and checks for services managed by
this charm.
func-test-pr: openstack-charmers/zaza-openstack-tests#436
Change-Id: Ice5eada838626059f8cb2c427f7b9b0884317660
Closes-Bug: #1897809
Related-Bug: #1933643
Co-authored-by: Aurelien Lourot <aurelien.lourot@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple test for the Designate application to ensure that the NRPE
checks for services have been created.
Related-Bug: #1897809