Add ldap group/membership tests #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arif-ali
changed the title
|
This passed with This is from the test test_102_keystone_ldap_group_membership, maybe requires extra policy changes |
arif-ali
force-pushed
the
ldap-groups-membership-tests
branch
from
5b8133d
to
012e2d5
Compare
arif-ali
force-pushed
the
ldap-groups-membership-tests
branch
from
012e2d5
to
9956b80
Compare
arif-ali
changed the title
arif-ali
force-pushed
the
ldap-groups-membership-tests
branch
from
9956b80
to
e071025
Compare
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 18.31% 18.22% -0.10%
==========================================
Files 158 158
Lines 9094 9140 +46
==========================================
Hits 1666 1666
- Misses 7428 7474 +46
Continue to review full report at Codecov.
|
|
This will conflict and add on to of #458 |
|
func-smoke: https://paste.ubuntu.com/p/HwdQjqdmc3/ after making the following modifications diff --git a/src/test-requirements.txt b/src/test-requirements.txt
index d3c9be8..3bd6c04 100644
--- a/src/test-requirements.txt
+++ b/src/test-requirements.txt
@@ -5,4 +5,4 @@
#
# Functional Test Requirements (let Zaza's dependencies solve all dependencies here!)
git+https://github.com/openstack-charmers/zaza.git#egg=zaza
-git+https://github.com/openstack-charmers/zaza-openstack-tests.git#egg=zaza.openstack
+git+https://github.com/arif-ali/zaza-openstack-tests.git@ldap-groups-membership-tests#egg=zaza.openstack |
arif-ali
force-pushed
the
ldap-groups-membership-tests
branch
from
e071025
to
fa9eb85
Compare
arif-ali
force-pushed
the
ldap-groups-membership-tests
branch
from
fa9eb85
to
f390cd1
Compare
arif-ali
force-pushed
the
ldap-groups-membership-tests
branch
from
f390cd1
to
5860d7c
Compare
lourot
suggested changes
Nov 25, 2020
Adds a test to check for groups that are coming from LDAP. Adds a test to ensure that openstack is able to check the membership of a user in the group. Signed-off-by: Arif Ali <arif.ali@canonical.com>
arif-ali
force-pushed
the
ldap-groups-membership-tests
branch
from
5860d7c
to
90aca8b
Compare
lourot
approved these changes
Nov 27, 2020
openstack-mirroring
pushed a commit
to openstack/charm-keystone-ldap
that referenced
this pull request
Nov 27, 2020
Adding the the group_name_attribute, as this was missed in the previous review. func-test-pr: openstack-charmers/zaza-openstack-tests#438 Depends-On: https://review.opendev.org/c/openstack/charm-keystone-ldap/+/748364 Change-Id: I9fe650704606317b337978ea9d8fec3a09c2b50f
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Nov 27, 2020
* Update charm-keystone-ldap from branch 'master'
to ce279129db48d675797a13695c2d9b5eb0be507e
- Add group_name_attribute as a config attribute
Adding the the group_name_attribute, as this was missed in the previous
review.
func-test-pr: openstack-charmers/zaza-openstack-tests#438
Depends-On: https://review.opendev.org/c/openstack/charm-keystone-ldap/+/748364
Change-Id: I9fe650704606317b337978ea9d8fec3a09c2b50f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to check for groups that are coming from LDAP.
Adds a test to ensure that openstack is able to check the membership
of a user in the group.
Signed-off-by: Arif Ali arif.ali@canonical.com