designate: test new configuration options #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
+ Coverage 17.79% 18.28% +0.49%
==========================================
Files 165 160 -5
Lines 10539 9359 -1180
==========================================
- Hits 1875 1711 -164
+ Misses 8664 7648 -1016
Continue to review full report at Codecov.
|
freyes
force-pushed
the
bug/1902923
branch
2 times, most recently
from
7292ad7
to
cf5fbfa
Compare
lourot
reviewed
Apr 26, 2021
| @@ -33,6 +33,8 @@ | |||
| class BaseDesignateTest(test_utils.OpenStackBaseTest): | |||
| """Base for Designate charm tests.""" | |||
|
|
|||
| DESIGNAME_CONF = '/etc/designate/designate.conf' | |||
|
|
||
| logging.debug('Tidy up delete test record %s' % domain_id) | ||
| self._wait_on_domain_gone(domain_id) | ||
| logging.debug('Donde with deletion of domain %s' % domain_id) |
New configuration options: - default-ttl - default-soa-minimum - default-soa-refresh-min - default-soa-refresh-max - default-soa-retry Related-Bug: #1902922
lourot
approved these changes
Jul 15, 2021
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 4, 2021
* Update charm-designate from branch 'master'
to fa48d3d7cf5fafd157b3d3f1570c63660f4a59dc
- Merge "Add config options to handle SOA records."
- Add config options to handle SOA records.
New configuration options:
- default-ttl
- default-soa-minimum
- default-soa-refresh-min
- default-soa-refresh-max
- default-soa-retry
Change-Id: I2ad0aec7d50a36e9e5227a08295aef4e99130d78
Closes-Bug: #1902923
Func-Test-Pr: openstack-charmers/zaza-openstack-tests#457
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Aug 4, 2021
New configuration options: - default-ttl - default-soa-minimum - default-soa-refresh-min - default-soa-refresh-max - default-soa-retry Change-Id: I2ad0aec7d50a36e9e5227a08295aef4e99130d78 Closes-Bug: #1902923 Func-Test-Pr: openstack-charmers/zaza-openstack-tests#457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New configuration options:
Related-Bug: #1902922