Add NovaComputeActionTest test class for virsh_audit action #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 18.23% 18.21% -0.02%
==========================================
Files 158 158
Lines 9181 9188 +7
==========================================
Hits 1674 1674
- Misses 7507 7514 +7
Continue to review full report at Codecov.
|
openstack-mirroring
pushed a commit
to openstack/charm-nova-compute
that referenced
this pull request
Jun 11, 2021
This new action to list instances as
virsh sees them on the node (virsh
list --all), sometimes this disagrees
with what nova thinks
Add a new zaza functional test class to
avoid breaking the older versions
To run the action, issue command:
$ juju run-action nova-compute/0 virsh-audit --wait
unit-nova-compute-0:
UnitId: nova-compute/0
id: "134"
results:
virsh-domains: |2+
Id Name State
-----------------------------------
1 instance-00000001 running
2 instance-00000002 running
status: completed
timing:
completed: 2020-12-08 11:05:02 +0000 UTC
enqueued: 2020-12-08 11:04:58 +0000 UTC
started: 2020-12-08 11:05:01 +0000 UTC
Closes-Bug: #1907409
func-test-pr: openstack-charmers/zaza-openstack-tests#472
Change-Id: I222a119199ada82186e2058402a31a40baf7fd7b
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jun 11, 2021
* Update charm-nova-compute from branch 'master'
to 203140252c5f1cc417e9ddd45c8927edf02711b9
- Merge " Add 'virsh-audit' action in nova-compute"
- Add 'virsh-audit' action in nova-compute
This new action to list instances as
virsh sees them on the node (virsh
list --all), sometimes this disagrees
with what nova thinks
Add a new zaza functional test class to
avoid breaking the older versions
To run the action, issue command:
$ juju run-action nova-compute/0 virsh-audit --wait
unit-nova-compute-0:
UnitId: nova-compute/0
id: "134"
results:
virsh-domains: |2+
Id Name State
-----------------------------------
1 instance-00000001 running
2 instance-00000002 running
status: completed
timing:
completed: 2020-12-08 11:05:02 +0000 UTC
enqueued: 2020-12-08 11:04:58 +0000 UTC
started: 2020-12-08 11:05:01 +0000 UTC
Closes-Bug: #1907409
func-test-pr: openstack-charmers/zaza-openstack-tests#472
Change-Id: I222a119199ada82186e2058402a31a40baf7fd7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #1907409 requested to add a new action 'virsh-audit' to list instances as virsh sees them on the compute node (virsh list --all) (sometimes this disagrees with what nova thinks). This PR added testcase 'test_virsh_audit_action' into new test class 'NovaComputeActionTest'
gerrit review link: https://review.opendev.org/c/openstack/charm-nova-compute/+/766412