migrate glance-simplestreams-sync from Amulet to Zaza #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoqiao
force-pushed
the
migrate-gss
branch
3 times, most recently
from
1861c49
to
2188fc2
Compare
guoqiao
added a commit
to guoqiao/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 9, 2019
In Amulet, we only run ssl test on xenial_pike. In Zaza, we will run non-ssl and ssl test on each bundle. This is done via `tests` section in tests/tests.yaml. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Signed-off-by: Joe Guo <guoqiao@gmail.com>
guoqiao
added a commit
to guoqiao/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 9, 2019
This patch migrate tests from Amulet to Zaza, and Python3 only. Changes about SSL test: In Amulet, we only run SSL test on xenial_pike. In Zaza, we will run non-SSL and SSL test on each bundle. This is done via adding extra test class to `tests` section in tests/tests.yaml. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234 Signed-off-by: Joe Guo <guoqiao@gmail.com>
thedac
suggested changes
Sep 9, 2019
There was a problem hiding this comment.
Please add the test_110_local_product_stream test [1]
Regarding the SSL testing. It seems like we are duplicating a lot of code here to generate certificates. And it is also not our prefered deployment method.
Let's consider adding vault to the bundle with the certificates relation instead. This may need to be added to the glance-simplestreams-sync charm.
guoqiao
added a commit
to guoqiao/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 10, 2019
This patch migrate tests from Amulet to Zaza, and Python3 only. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234 Signed-off-by: Joe Guo <guoqiao@gmail.com>
guoqiao
force-pushed
the
migrate-gss
branch
2 times, most recently
from
5175dd2
to
53c76c2
Compare
Migrate tests from Amulet to Zaza in:
charm-glance-simplestreams-sync/tests/basic_deployment.py
Signed-off-by: Joe Guo <guoqiao@gmail.com>
guoqiao
force-pushed
the
migrate-gss
branch
from
53c76c2
to
63e9b4c
Compare
guoqiao
added a commit
to guoqiao/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 10, 2019
This patch migrate tests from Amulet to Zaza, and Python3 only. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234 Signed-off-by: Joe Guo <guoqiao@gmail.com>
guoqiao
added a commit
to guoqiao/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 11, 2019
This patch migrate tests from Amulet to Zaza, and Python3 only. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234 Signed-off-by: Joe Guo <guoqiao@gmail.com>
guoqiao
added a commit
to guoqiao/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 11, 2019
This patch migrate tests from Amulet to Zaza, and Python3 only. SSL is enabled for all bundles with charm-vault. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234 Signed-off-by: Joe Guo <guoqiao@gmail.com>
guoqiao
added a commit
to guoqiao/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 12, 2019
This patch migrate tests from Amulet to Zaza, and Python3 only. SSL is enabled for all bundles with charm-vault. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234 Signed-off-by: Joe Guo <guoqiao@gmail.com>
guoqiao
added a commit
to guoqiao/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 12, 2019
This patch migrate tests from Amulet to Zaza, and Python3 only. SSL is enabled for all bundles with charm-vault. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234 Signed-off-by: Joe Guo <guoqiao@gmail.com>
openstack-gerrit
pushed a commit
to openstack/charm-glance-simplestreams-sync
that referenced
this pull request
Sep 12, 2019
This patch migrate tests from Amulet to Zaza, and Python3 only. SSL is enabled for all bundles with charm-vault, except trusty, which is not supported by vault. func-test-pr: openstack-charmers/zaza-openstack-tests#55 Partial-Bug: 1828424 Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234 Signed-off-by: Joe Guo <guoqiao@gmail.com>
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Sep 12, 2019
* Update charm-glance-simplestreams-sync from branch 'master'
- Migrate from Amulet to Zaza
This patch migrate tests from Amulet to Zaza, and Python3 only.
SSL is enabled for all bundles with charm-vault, except trusty, which is
not supported by vault.
func-test-pr: openstack-charmers/zaza-openstack-tests#55
Partial-Bug: 1828424
Change-Id: I4dacf33d3ab4dedbbe62a36b1b2ce5606e51d234
Signed-off-by: Joe Guo <guoqiao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Amulet tests from charm-glance-simplestreams-sync/tests/, include SSL tests.