added glance functional test for image-conversion config #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 18.13% 18.08% -0.05%
==========================================
Files 163 163
Lines 10313 10349 +36
==========================================
+ Hits 1870 1872 +2
- Misses 8443 8477 +34
Continue to review full report at Codecov.
|
lourot
suggested changes
May 28, 2021
| def import_image_to_glance(glance, local_path, image_name, | ||
| disk_format='qcow2', visibility='public', | ||
| container_format='bare'): | ||
| """Creates, stages and import an image. |
There was a problem hiding this comment.
I'm not an Glance expert: can you explain in the docstring a bit the difference with upload_image_to_glance()? What's the difference between "uploading" and "staging/importing" an image?
| logging.info('Downloading {} ...'.format(image_url)) | ||
| download_image(image_url, local_path) | ||
| else: | ||
| logging.info('Cached image found at {} - Skipping download'.format( |
There was a problem hiding this comment.
you're duplicating code from create_image(). Can we refactor in order not to duplicate code?
lourot
approved these changes
May 31, 2021
|
This needs to be merged at the same time as https://review.opendev.org/c/openstack/charm-glance/+/792065 , when ready |
openstack-mirroring
pushed a commit
to openstack/charm-glance
that referenced
this pull request
Jun 1, 2021
image-convertion config enables image convertion to raw format this optimizes back-end capabilities while not putting the burden of converting images to their end users func-test-pr: openstack-charmers/zaza-openstack-tests#582 Closes-Bug: 1899767 Change-Id: Id3791721f9e38899c87b88591cdc42e46ffea5c1
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jun 1, 2021
* Update charm-glance from branch 'master'
to 4aaa2ce5a34679a753e261f90f16c7e5bc0c05f9
- add config to enable convertion to raw format
image-convertion config enables image convertion to raw format
this optimizes back-end capabilities while not putting the burden
of converting images to their end users
func-test-pr: openstack-charmers/zaza-openstack-tests#582
Closes-Bug: 1899767
Change-Id: Id3791721f9e38899c87b88591cdc42e46ffea5c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional test for image-conversion feature added in https://review.opendev.org/c/openstack/charm-glance/+/792065
Test does:
raw