Implement the tests for the cinder-lvm charm #626
Conversation
The cinder-lvm charm is a subordinate of the cinder charm. The spec can be found here: https://github.com/openstack/charm-specs/blob/master/specs/xena/backlog/cinder-lvm.rst
This brings the changes from the 'cinder-lvm' repo itself, from where this class will be removed.
| """Test creating a volume after remove missing ones in a group.""" | ||
| self._create_volume() | ||
|
|
||
| @with_conf('cinder-lvm', {'remove-missing-force': 'true'}) |
There was a problem hiding this comment.
IIUC this under the hood should end up calling vgreduce --removemissing ..., I think you may need to setup a scenario where there are VGs referencing missing PVs so we are certain that under those circumstances it's possible to create volumes.
There was a problem hiding this comment.
@freyes as discussed a couple days ago, cinder makes it hard to actually test this in a clean manner, since only a single volume name can be configured as opposed to a comma-separated list. We could, of course, manually create them in the tests, but it will end up polluting the test environment, since all the LVM stuff are global settings and can't be isolated.
There was a problem hiding this comment.
I think this is a good test to have. Yes, it will manipulate the test environment - but that can be done as the last test to run so it doesn't inadvertently pollute other tests that are exercised. However, I think I'm comfortable with this being a subsequent improvement to the cinder-lvm tests as long as @lmlg is willing to commit to do those in a follow-on patch.
There was a problem hiding this comment.
I can absolutely commit them in a follow up PR.
Instead of introducing a new decorator to temporarily change the configuration, use the existing infrastructure. Furthermore, avoid passing the model name in some calls since it's implied already.
Instead of using '/dev/vdc' for a test, use a loop device, since it should always be available and it allows us to set a specific size for it.
The cinder-lvm charm is a subordinate of the cinder charm. The spec
can be found here:
https://github.com/openstack/charm-specs/blob/master/specs/xena/backlog/cinder-lvm.rst